Geta / geta-optimizely-genericlinks

An extensive alternative to LinkItemCollection in Optimizely.
Apache License 2.0
4 stars 0 forks source link

LinkDataCollection inside a property list causes property list to stop working #24

Closed victortranstockland closed 9 months ago

victortranstockland commented 1 year ago

When there is a LinkDataCollection inside a property list, the property list stops responding correctly - images cannot be dragged from the media gallery and updates stop being saved to the database.

Optimizely CMS 12.19.0 Optimizely CMS UI 12.23.0

GeekInTheNorth commented 1 year ago

@victortranstockland I'm having a similar issue on the latest version of the Optimizely CMS where actually the Content Item does not fully load in the CMS Editor Interface.

public class NavigationConfigurationPage : PageData
{
// These properties load
    public virtual string? MainNavigationPrimaryTitle { get; set; }

    public virtual ContentReference? MainNavigationPrimaryImage { get; set; }

// This property does not load
    public virtual LinkDataCollection<LinkItemWithImage>? MainNavigationPrimaryLinks { get; set; }

// Subsequent properties also do not appear to load after the failure on the above property.
    public virtual string? MainNavigationSecondaryTitle { get; set; }

    public virtual ContentReference? MainNavigationSecondaryImage { get; set; }

    public virtual LinkDataCollection<LinkItemWithImage>? MainNavigationSecondaryLinks { get; set; }
}
svenrog commented 11 months ago

I couldn't reproduce this. Although I've fixed a related issue in #25 with version 1.8.1, you can try testing that. It might be the same issue.

svenrog commented 11 months ago

Nuget found here.

GeekInTheNorth commented 11 months ago

Hello @svenrog I'll see if I can reproduce the issue with the fix in place and get back to you

victortranstockland commented 11 months ago

@svenrog Looks like my issue was resolved in 1.8.1.