search

Geta / geta-optimizely-genericlinks

An extensive alternative to LinkItemCollection in Optimizely.
Apache License 2.0
4 stars 0 forks source link

Properties not coming out in ContentApi calls #6

Closed natbredenkamp closed 2 years ago

natbredenkamp commented 2 years ago

seems these properties are not included in the ContentApi responses by default. do I need to create a PropertyModel<??, ??> and Converter for each of them? not sure of the most useful backing type to use

svenrog commented 2 years ago

We haven't tested this with the ContentAPI yet, I suspect you have to create a converter for them at least. LinkDataBackingTypeResolverInterceptor automatically assigns all instances of LinkData and LinkDataCollection<TLinkData> to PropertyLinkData and PropertyLinkDataCollection respectively. You should use those as backing types. Try it out.

svenrog commented 2 years ago

I welcome feedback on what solution you landed on, maybe we can include something similar in the package.

svenrog commented 2 years ago

Support for EPiServer.ContentDeliveryApi was added in version 1.4.0. Check out the docs on how to add it.

Before the nuget is officially released, you can download it manually or just copy the implementation from here.

Check it out and see if it works for you.

svenrog commented 2 years ago

Version 1.4.0 is now released on Optimizely nuget feed as Geta.Optimizely.GenericLinks.ContentDeliveryApi. Please open a new issue if there is something wrong with the implementation.