search

Geta / geta-optimizely-tags

Geta Tags is a library that adds tagging functionality to Optimizely content.
Apache License 2.0
0 stars 3 forks source link

Change tag-it to tagify and upgrade bootstrap #21

Closed NathanBeddoeWebDev closed 11 months ago

NathanBeddoeWebDev commented 1 year ago

Summary Addresses https://github.com/Geta/geta-optimizely-tags/issues/18

Our team wants to be able to use Geta Tags for our site, but we don't want to reintroduce Jquery. tag-it looks like it's recently deprecated in favor of tagify which is a jquery-less solution. Bootstrap has also removed jquery in version 5, thus I believe we can remove Jquery from Geta Tags.

Note Just a heads up, I've never developed Episerver widgets or UI components before and I'm not super competent with either Dojo or AMD modules.

One part where this is apparent is where I'm loading cdn scripts directly into our define dependencies. I did originally have something like "Geta.Optimizely.Tags/1.0.0/ClientResources/vendor/tagify.min.js" which was working in development, but I don't think it was going to work when I packed it with a proper version. If you've got a better way to load vendor scripts into AMD, I'm all ears.

Utilizes https://github.com/yairEO/dragsort and https://github.com/yairEO/tagify

NathanBeddoeWebDev commented 1 year ago

Just sorting out the allowSpaces option, tagify has some weird options around that.