Getbeans / Beans

Beans WordPress Theme Framework. The default branch is set to development, please switch to the master branch for production.
https://www.getbeans.io
Other
392 stars 61 forks source link

Beans default focus styling issue on Safari #320

Closed itsdanreed closed 6 years ago

itsdanreed commented 6 years ago

The default :focus styling in tm-beans/lib/assets/less/style.less (snippet included) causes outline when clicking elements in article, aside and the navigation on Safari 11.1.2.

Source:

/* Display outline on focus */
:focus {
    color: #333;
    outline: 1px #ccc solid;
}

Screenshot:

screen shot 2018-08-08 at 2 21 15 pm
ibes commented 6 years ago

Hm - for accessability reasons there should be outlines.

Focus is for tabbing through the page. Without outline people with vision won't know where they are.

I agree that outlines look shitty - but as far as I know they are best practise.

itsdanreed commented 6 years ago

@ibes I would agree that it seems intentional, but it seems except the same issue does not exist on Chrome?

christophherr commented 6 years ago

Just to confirm, this is intentional. The outline appears in Chrome, too. It actually overrides the Chrome user agent outline styles which are thicker and blue :focus { outline: -webkit-focus-ring-color auto 5px; } You can change the styles in your child theme's stylesheet.

christophherr commented 6 years ago

Closing this issue because the addition was intentional to improve accessibility and the :focus styles can be changed in a child theme's stylesheet.