search

Getbeans / Beans

Beans WordPress Theme Framework. The default branch is set to development, please switch to the master branch for production.
https://www.getbeans.io
Other
391 stars 61 forks source link

Change `tm-beans` to `beans #59

Open hellofromtonya opened 6 years ago

hellofromtonya commented 6 years ago

In versions < 2.0, Beans' child themes set the Template (parent theme) as tm-beans. Within Beans, the text domain is set to tm-beans. The proposal is to change these to beans for naming consistency.

This change will also draw a line in the sand to differentiate an installation:

  1. of tm-beans as version 1.x.x (which is PHP 5.2.x)
  2. and beans as version 2.x.x (which is PHP 5.6)
hellofromtonya commented 6 years ago

Here's the backstory on the prefixing:

Why is it prefixed with tm-? @ThierryA is protecting Beans in the event that someone submits a theme named "Beans" to the WordPress theme repository.

Why is that a problem?

If there's a theme in the WordPress theme repository with the same name, then the automatic updater will think our Beans Framework is actually that other theme. Not good and confusing to the site owner. The prefix prevents that from happening (well, unless someone names it tm-beans).

You'll notice that the example child themes have their parent listed as Template: tm-beans in the style.css file. That would mean you need to rename the wp-content/themes/beans folder to wp-content/themes/tm-beans.

This issue will address the problem, protect Beans, and keep the branding consistent.

Codewryter commented 6 years ago

Will this theme be submitted to the repository?

hellofromtonya commented 6 years ago

@Codewryter Issue #61 covers that topic. As it's a framework and not a theme, typically the core theme review team frowns on submission.

But we have other things up our sleeves to ensure updates are handled will protecting beans.