Minor improvements of CLI output

Getdeck / getdeck

A CLI that creates reproducible Kubernetes environments for development and testing

https://getdeck.dev

Apache License 2.0

90 stars 2 forks source link

Minor improvements of CLI output #117

Open tschale opened 1 year ago

tschale commented 1 year ago

What is the new feature about?

When no deckfile is specified, i.e. running with deck get ., the output is [INFO] Reading Deckfile: .. This could be changed to [INFO] Reading Deckfile: deck.yaml, as deck.yaml is the default.
When a local cluster already exists, the output of get is [INFO] Cluster already exists, starting it. This could be enhanced so that the clustername is included, such as it is when a new cluster is created.

Why would such a feature be important to you?

Minor output improvements in the vein of "explicit is more implicit"

Anything else we need to know?

No response

buschNT commented 1 year ago

This issue was solved with version 0.11.1

tschale commented 1 year ago

I can confirm the first one, however when running deck get when the cluster already exists, I still get following output:

[INFO] Cluster already exists, starting it

buschNT commented 1 year ago

I can confirm the first one, however when running deck get when the cluster already exists, I still get following output:

True, furthermore the [INFO] Reading Deckfile: . still exists when there is no deck.yml in the cwd.

tschale commented 1 year ago

I found another small thing, what do you think about adding http:// to the ingress output? Currently it's the following:

[INFO] Ingress: foo.127.0.0.1.nip.io -> /admin
[INFO] Ingress: foo.127.0.0.1.nip.io -> /

If it would be http://foo.127.0.0.1.nip.io it would be directly clickable from the terminal. Of course one might have https configured, however I would expect there to be a redirect to https from http.

tschale commented 1 year ago

Just another thing that I realized. I was using the -I flag to install the deckfile-resources into my current kubecontext, which was a GKE cluster. In the output I also got [INFO] Cluster already exists, starting it.

When using the -I flag, getdeck won't be able to start a cluster, or would it? Shall we change the output of that line completely, or even omit it when using -I?

Also when an error occurs, I get the output [ERROR] There was an error installing the workload. Now removing the cluster.. What happens when using the -I flag, as my cluster still exists, I assume that we don't actually try to remove a cluster. The second sentence of the error-message could just be removed in such a case.