GetmeUK / ContentEdit

A JavaScript library that provides a set of classes for building content-editable HTML elements.
http://getcontenttools.com/api/content-edit
MIT License
253 stars 51 forks source link

Added PREFER_LINE_BREAKS setting, #2

Closed Qqwy closed 8 years ago

Qqwy commented 8 years ago

This pull-request is related to this issue on the ContentTools library: https://github.com/GetmeUK/ContentTools/issues/150

It adds the PREFER_LINE_BREAKS setting that swaps the way Enter and Shift+Enter behave.

anthonyjb commented 8 years ago

Hi @Qqwy thank you for this, will happily merge into the core library however before I can do that please update the tests for the return key behaviour in ContentEdit.Text elements to cover this new behaviour.

If you need a hand on this (the test spec is not an area I'm especially proud off) or don't have time to let me know and I'll merge and update at the weekend.

anthonyjb commented 8 years ago

Hi @Qqwy ok so I've taken the changes here directly and applied them to the repo, I change the comments and added tests for the new flag but I credited you and referenced this pull request in the commit message. Thank you for adding this feature.