Save doesn't work when the last action is the deletion of a table header - Githubissues

GetmeUK / ContentTools

A JS library for building WYSIWYG editors for HTML content.

http://getcontenttools.com

MIT License

3.97k stars 399 forks source link

Save doesn't work when the last action is the deletion of a table header #194

Closed nxu closed 8 years ago

nxu commented 8 years ago

I encountered something strange: when I edit a contentable area and the last action I do is deleting a table header (clicking inside the thead and pressing delete), then click save, the buttons disappear and there is no saving perfomed, the editor kind of dies.

Could this be some kind of a bug, or am I doing something wrong? Thanks in advance!

anthonyjb commented 8 years ago

Hi @nXu thanks for the information.

I've tried to reproduce this error as you've described a couple of times now both using the sandbox in the repo and demo page on the website but I'm unable to. This doesn't mean this isn't a bug though just that I can't reproduce it to fix, can you provide me with:

Any error information output to the console during your editing session.
Can you try to reproduce with the sandbox or demo editors and if you can send me instructions on how to do so so I can track it down.

Thanks for your help in advance.

nxu commented 8 years ago

Thanks for your quick answer, @anthonyjb I could not reproduce the error in the sandbox either, it must be an error in my integration somewhere. I'll try my best to debug.

wotta commented 8 years ago

@nXu did you already figured it out and is it solved or not yet ?

anthonyjb commented 8 years ago

@concept-core if you're able to reproduce the area @concept-core please let me know (ideally using the demo or sandbox page) as we weren't able to making it difficult to follow up on this.

wotta commented 8 years ago

@anthonyjb I will try to do this tomorrow.

It seams it's something I encounterd to but I am not completely sure. If I cannot recreate it and he doesn't respond you can close this issue until further notice.

nxu commented 8 years ago

I was not yet able to figure out the reason as I haven't really taken the time, but it apparently doesn't always happen. I can't reproduce it in the online demo so I think it has something to do with how I integrated ContentTools, but for the most part, I just copypasted the code from the Getting started guide

wotta commented 8 years ago

It is possible that you changed the ajax request and you got a 500 error. I had that happen and I only saw a gear icon.

I am not sure if that is what you saw.

wotta commented 8 years ago

@nXu @anthonyjb This is what I have encounterd when I saved to a page that returned a 500 internal server error. I think this is the closest I can get the to actual problem.

The gear icon keeps spinning and doesn't show a actual error for the user. http://s32.postimg.org/n5av7e2cl/Schermafbeelding_2016_05_02_om_09_46_46.png

nxu commented 8 years ago

@concept-core My error is most likely not related. There is no request being sent, there's just a JS error: content-tools.js:3523 Uncaught TypeError: Cannot read property 'innerHTML' of null

wotta commented 8 years ago

@nXu What version of contenttools are you running and do you have a demo of the how you implemented it ?

anthonyjb commented 8 years ago

Closing as we don't have a reproducable error report but if someone can reproduce the error and provide steps for doing so that would be a big help and I'll re-open the issue.