search

GetmeUK / ContentTools

A JS library for building WYSIWYG editors for HTML content.
http://getcontenttools.com
MIT License
3.95k stars 395 forks source link

detach() or detatch() ? #404

Closed damienflament closed 7 years ago

damienflament commented 7 years ago

The current documentation about the ComponentUI mention a detach() method. But this method is called detatch in the source code and in the specification also.

anthonyjb commented 7 years ago

@damienflament should be detach - misspelled in the source - I'll upload a patch early this week -ty :+1:

damienflament commented 7 years ago

Isn't it a source of serrious bugs ? Even if you're not aware of them (because the detach method is defined in the "subclasses" of your projects) ?

anthonyjb commented 7 years ago

@damienflament the detatch\detach method isn't called in the ContentTools libraries, though other external libraries may use it.

The patch I implement will retain the existing detatch method with a warning recommendation output in the console to switch to the correct detach method by the next minor update. This will mean the change has no impact on existing projects and the version change will be a patch 1.3.2 -> 1.3.3.

I don't consider this a serious bug as the modification will be backwards compatible and the existing detatch will remain until the next minor update (major.minor.patch).