GetmeUK / ContentTools

A JS library for building WYSIWYG editors for HTML content.
http://getcontenttools.com
MIT License
3.97k stars 399 forks source link

Color extension #466

Open cmangen opened 6 years ago

cmangen commented 6 years ago

Hi Anthony,

ContentTools is really awesome.

As I understood it correctly, you don't like a color selector in ContentTools. Will such a feature be a lot of work? We can consider paying for this feature.

Thank you very much in advanced.

chang-zhao commented 6 years ago

IMHO inline styling with a couple of buttons (color & background-color) with drop-down pickers isn't a very complex task (though we would need to handle cases when the selected-for-coloring range overlaps elements with already existing color attributes).

But then that solution might be not the most useful - perhaps you would like to have only several specific colors on your page. Then it would be useful to keep a page colors palette, and perhaps a site-wide palette, create custom-color classes for them, and add that functionality to color picker buttons.

It's not too complex to consider to implement; it could be a very nice and useful feature.

anthonyjb commented 6 years ago

@cmangen I can certainly create this for you or help you integrate an existing colour picker if that's your preference (email me at ant[at]getme.co.uk), however, if you're considering implementing this yourself (especially if you're going to use an existing 3rd-party colour picker component) it shouldn't be difficult.

There are several other developers who've created color picking tools for ContentTools as part of their editing environment (@bfintal certainly has), and they may well be willing to share some code here to help you get started.

graydwarf commented 6 years ago

fwiw: I was also interested in having a color picker as well for changing font colors.

On Mon, Jan 1, 2018 at 8:03 AM, Anthony Blackshaw notifications@github.com wrote:

@cmangen https://github.com/cmangen I can certainly create this for you or help you integrate an existing colour picker if that's your preference (email me at ant[at]getme.co.uk), however, if you're considering implementing this yourself (especially if you're going to use an existing 3rd-party colour picker component) it shouldn't be difficult.

There are several other developers who've created color picking tools for ContentTools as part of their editing environment (@bfintal https://github.com/bfintal certainly has), and they may well be willing to share some code here to help you get started.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GetmeUK/ContentTools/issues/466#issuecomment-354660784, or mute the thread https://github.com/notifications/unsubscribe-auth/AFx-QygF7hEsAQ0X4Ydzg4RVOGpZ00mEks5tGQGzgaJpZM4RONeX .

cmangen commented 6 years ago

@anthonyjb Thank you very much for your answer. Yes, I want to insert an existing one.

STPJ commented 6 years ago

Is this was implemented somewhere?