search

GetoXs / MediatR.Extensions.FluentValidation.AspNetCore

MediatR extension to FluentValidation for .NET framework
MIT License
65 stars 6 forks source link

Update FluentValidation to 9.0.1 #3

Closed denis-ivanov closed 4 years ago

denis-ivanov commented 4 years ago

I tried to use MediatR.Extensions.FluentValidation.AspNetCore 1.0.3 with FluentValidation 9.0.1 and it fails in runtime with exception MethodNotFoundException bucause they added additional parameter filter to ServiceCollectionExtensions.AddValidatorsFromAssemblies.

GetoXs commented 4 years ago

I have investigate that issue, you have a right there is MissingMethod exception. But I have managed that different way. You can check latest commits. Btw. I wrote down some test using latest FluentValidation version so it should be easier to check it.

GetoXs commented 4 years ago

Here is new version: https://www.nuget.org/packages/MediatR.Extensions.FluentValidation.AspNetCore/1.1.0 Please check if everything is correct.

Additonally I setup github Action CI, so we dont need to think about mistakes during PR. https://github.com/GetoXs/MediatR.Extensions.FluentValidation.AspNetCore/actions

GetoXs commented 4 years ago

I hope everything works fine. For now I close this PR without merge.