GewoonJaap / WinWhisper

Create subtitles with ease, using Whisper AI for Windows
42 stars 7 forks source link

No longer works :( #10

Closed hirowa closed 10 months ago

hirowa commented 10 months ago

I've tried multiple things:

Used both versions

And I always get the following error, and the the terminal closes itself. I've checked the model is indeed in the rgith folder, so I don't know what's wrong :(

Untitled

GewoonJaap commented 10 months ago

:( I am going to investigate. As far as I know I haven't touched a single line of code regarding the whisperAI it self. Will try to reproduce this error on my end and fix it.

hirowa commented 10 months ago

Found the problem, it appears this instance doesn't like to wait to download the model heheh (it downloaded only 25mb/145mb), so I copied the previous model into the new folder and it works!

The problem I have now is that even if I set up a custom output folder it still output in the default system folder.

GewoonJaap commented 10 months ago

Ohh, thanks! I might know what the issue is then. It probably is downloading and already starts a new video to process, which then thinks the model already exists

GewoonJaap commented 10 months ago

Will fix both errors probably tomorrow or Saturday. If you see any other bugs please send them to me so I can patch those as well :)

hirowa commented 10 months ago

Thank you so much for your hard work! Will do! :)

GewoonJaap commented 10 months ago

I have fixed the model loading issue, sadly I am not able to replicate the outputFolder issue. I do have added logging in case the outputFolder isn't valid.

I tried manually copy and pasting the output path as well as dragging the folder into the terminal window. Both worked fine

GewoonJaap commented 10 months ago

I am closing this issue due to inactivity. Feel free to re-open when necessary

hirowa commented 10 months ago

Hi @GewoonJaap, sorry, was really busy, the folder issue still persist for me. I've deleted previous versions and cleaned the %appdata% local folder. So I don't know what I'm doing wrong. (See video)


I discovered that If I manually delete the quotation marks it works as intended! Is there a way to allow it to have quotation marks? Maybe something like directory = input("Please enter the folder path: ").strip('"')

https://github.com/GewoonJaap/WinWhisper/assets/42184093/fc2011d8-c98f-48d4-bd12-885ca31c32fc

GewoonJaap commented 10 months ago

Aha, I forgot to test the edge case where folders have spaces in them thus causing " to be inserted. Will patch this :)

hirowa commented 10 months ago

Thanks!

GewoonJaap commented 10 months ago

This has been fixed in V1.3.1, which is published :)

hirowa commented 10 months ago

Thank you, you're amazing, works like a charm :)

GewoonJaap commented 10 months ago

Great to hear it works amazing! Thanks for using the application and helping me make it better :)