search

GewoonJaap / WinWhisper

Create subtitles with ease, using Whisper AI for Windows
52 stars 8 forks source link

Fixed issue with reading files that are over 2GB #28

Closed KantorFitz closed 1 month ago

KantorFitz commented 2 months ago

Fixes the issue #25

GewoonJaap commented 2 months ago

Hi @KantorFitz Thanks for your PR. I didn't have time this weekend to look at it. The code changes look good but I will compile and test it when I am home today.

KantorFitz commented 2 months ago

Hi @KantorFitz Thanks for your PR. I didn't have time this weekend to look at it. The code changes look good but I will compile and test it when I am home today.

Sure, btw sorry for that second commit which is not strictly related to the main problem. Just say if it should be moved to separate PR and I will prepare one.

GewoonJaap commented 2 months ago

Ah that's fine, just keep it like this :D. It ain't a big change

GewoonJaap commented 1 month ago

Thanks for the PR, I just tested it and it works good! :)