GeyserExtensionists / GeyserModelEngine

MIT License
23 stars 10 forks source link

Entity does not change when model is swapped #10

Closed Ars3ne closed 3 months ago

Ars3ne commented 3 months ago

Hello! Firstly, I want to thank you for creating this amazing plugin and making it free and open source. I would not be motivated for porting my server to Bedrock if it was not publically available, and I am really grateful for you for that. However, I am having an small issue in regard to model swapping.

Some plugins like MythicMobs allow you to dynamically swap an active model for another one (such as, in the case of MythicMobs specifically, using the remapmodel mechanic). In my speficic case I'm using a boss which changes it's model depending on it's current state (it uses one model when spawned, another model when it starts fighting a player and a third model to indicate his 'second phase').

However, when those model changes are triggered and they are applied in Java, the changes end up not happening in Bedrock, resulting in visual and animation inconsistencies. Other mobs that are spawned using MythicMobs and use ModelEngine but are not swapped by a skill do not have this issue, and the other individual models of the boss used can be seen on Bedrock without problems if spawned by the command /meg summon.

On the images below, the first one shows the mob on Java edition and the second one shows it on Bedrock edition. Note that the Java mob has a different sword and has an illumination on it's body that the default model, the one still shown in Bedrock, does not have.

image1 image2

Once again, I'm really grateful for the creation of this tool and I would totally understand if you do not want to fix this due to an lack of time or interest, especially since the main functionality, which is showing MEG4 models in Java, is working perfectly otherwise.

Ars3ne commented 3 months ago

I managed to fix this issue on my own by manually removing and adding an new model when changing phases instead of using the remapmodel mechanic.