Incompatibility with Plan

GeyserMC / Floodgate-Modded

Port of the hybrid mode plugin called Floodgate for Fabric and NeoForge to allow for connections from Geyser to join online mode servers.

MIT License

52 stars 18 forks source link

Incompatibility with Plan #71

Closed AuroraLS3 closed 1 year ago

AuroraLS3 commented 1 year ago

Hello, a user sent me a report about server failing to start when both floodgate and plan are installed.

Plan fails to inject mixin to ServerPlayNetworkHandler, I think because it was modified earlier by floodgate

Log from user:

With floodgate and plan: https://paste.dedimc.io/upitovulig
With plan: https://paste.dedimc.io/odewidugor
Mixin that is failing to inject when floodgate is installed https://github.com/plan-player-analytics/Plan/blob/master/Plan/fabric/src/main/java/net/playeranalytics/plan/gathering/listeners/events/mixin/ServerPlayerEntityMixin.java#L32

I don't know how to go about fixing this so I'm opening this ticket.

Camotoy commented 1 year ago

Hey, thanks for letting us know. We don't have a Mixin in any player class, so it's probably one of our dependencies. By chance does the same behavior occur without Floodgate but with the Squaremap mod? (https://github.com/jpenilla/squaremap/) It uses many of the same dependencies (Cloud, Adventure) that Floodgate uses.

AnttiMK commented 1 year ago

Hey, Plan contributor here 👋🏼 The issue doesn't seem to happen with only Squaremap and Plan installed. However, it does occur when Geyser-Fabric is installed (regardless whether floodgate is installed or not), so it's probably not related to Floodgate, but actually Geyser itself. Are there any dependencies in Geyser that might cause this?

Camotoy commented 1 year ago

The only mod provided there is https://github.com/lucko/fabric-permissions-api.

Camotoy commented 1 year ago

Closing in favor of https://github.com/GeyserMC/Geyser/issues/3423, since this appears to not be tied to Floodgate-Fabric.