GeyserMC / Floodgate

Hybrid mode plugin to allow for connections from Geyser to join online mode servers.
https://geysermc.org
MIT License
573 stars 171 forks source link

Converted skin uses incorrect skin model #297

Closed mooziii closed 2 years ago

mooziii commented 2 years ago

Describe the bug

When a bedrock player has a slim skin, it will be shown as a classic skin for java players.

To Reproduce

  1. Put a slim skin on the bedrock account
  2. Join a java server
  3. The bedrock player will have a classic skin for all java players.

Expected behaviour

The player skin model should be slim for all players.

Screenshots / Videos

on bedrock:

bedrock image

on java:

java image 1 java image 2

Server Version and Plugins

No response

Geyser Dump

https://dump.geysermc.org/FVKs1rF6E1qTixYc4jlGFEJRH0aFyMuK

Geyser Version

2.0.2-SNAPSHOT (git-master-fb26e26)

Minecraft: Bedrock Edition Version

1.18.12

Additional Context

Im using floodgate.

dave9123 commented 2 years ago

I think it's because how Java renders avatar

Tim203 commented 2 years ago

I'm moving this to Floodgate since seeing Bedrock skins on Java Edition is a Floodgate feature.

Tim203 commented 2 years ago

I pushed a change to the skin converter yesterday. Could you try joining again with that skin and see if the same skin still produces this issue?

mooziii commented 2 years ago

newest build from jenkis image

Tim203 commented 2 years ago

In that case could you join test.geysermc.org:19100 with your Bedrock account? This allows me to see why your skin is being converted like that.

mooziii commented 2 years ago

image

Tim203 commented 2 years ago

Ah oops. I'll let you know when that has been fixed.

Tim203 commented 2 years ago

You should be able to connect now.

mooziii commented 2 years ago

yes image

Tim203 commented 2 years ago

I took a look at it today, and the converter says that it's an Alex skin. Because of that I'm closing this issue, as it should be fixed.