GeyserMC / Floodgate

Hybrid mode plugin to allow for connections from Geyser to join online mode servers.
https://geysermc.org
MIT License
575 stars 170 forks source link

Breaks Fabric runServer/runClient targets #373

Closed wereii closed 1 year ago

wereii commented 1 year ago

This is more of an FYI, not sure if it's something you can fix here.

net.fabricmc:fabric-loader uses org.objectweb.asm from org.ow2.asm:asm:9.3 but this mod includes it's own org.objectweb.asm implementation which is incompatible and will throw something along:

[13:44:43] [main/INFO] (FabricLoader/GameProvider) Loading Minecraft 1.19.3 with Fabric Loader 0.14.11
2022-12-12 13:44:43 INFO  FabricLoader/GameProvider:51 - Loading Minecraft 1.19.3 with Fabric Loader 0.14.11
[13:47:59] [main/ERROR] (FabricLoader) Uncaught exception in thread "main"
 java.lang.IllegalArgumentException: Unsupported class file major version 61

when running either one of the runX gradle tasks.

Konicai commented 1 year ago

Please use the Floodgate-Fabric repo for fabric issues

I believe I fixed this already in my 1.19.3 PR though

wereii commented 1 year ago

As far as I can see, Floodgate-Fabric is a main implementation of Floodgate as a mod for Fabric. I am talking about including floodgate:api in different fabric mod so it can interact with Floodgate.

Konicai commented 1 year ago

Ah, apologies for the misunderstanding. Yeah, something doesn't seem right here, I'll take a look in a bit.

wereii commented 1 year ago

Yeah no worries I should have given full details.

It does look like similar problem you fixed here https://github.com/GeyserMC/Floodgate-Fabric/pull/69/commits/c00b99c619a34543c01446cf835385fdcfac2da9

Konicai commented 1 year ago

This issue was basically described here: https://github.com/NikitaCartes/EasyAuth/pull/72

Pretty sure a commit to the master branch of Floodgate, or completing the development branch, would actually fix this issue.

wereii commented 1 year ago

Awesome, thanks!