search

GeyserMC / Floodgate

Hybrid mode plugin to allow for connections from Geyser to join online mode servers.
https://geysermc.org
MIT License
575 stars 170 forks source link

SkinApplyEvent is never triggered #426

Closed xknat closed 1 year ago

xknat commented 1 year ago

As a follow up from #403: We found out that the event SkinApplyEvent is not being executed.

In our testing setup, we did in fact register the event, just not in our public code:

https://github.com/SkinsRestorer/SkinsRestorerX/blob/dev/shared/src/main/java/net/skinsrestorer/shared/floodgate/FloodgateUtil.java https://github.com/SkinsRestorer/SkinsRestorerX/blob/dev/shared/src/main/java/net/skinsrestorer/shared/floodgate/FloodgateListener.java

We do register the event here: https://github.com/SkinsRestorer/SkinsRestorerX/blob/84765e53ccb73521de8e9a79f3fad1f03062bc67/shared/src/main/java/net/skinsrestorer/shared/plugin/SRPlugin.java#L402

xknat commented 1 year ago

Any ETA on this?

Tim203 commented 1 year ago

Hey, I just tried to see whether the event is fired and it's fired on all platforms.

xknat commented 1 year ago

Hey, I just tried to see whether the event is fired and it's fired on all platforms.

Did we register / handle the event wrong?

Tim203 commented 1 year ago

I was able to find the issue. This issue is (apparently) not covered by the unit tests and I only tested whether the event was fired, not with an actual subscriber. I'll be fixing this issue shortly.

xknat commented 1 year ago

I was able to find the issue. This issue is (apparently) not covered by the unit tests and I only tested whether the event was fired, not with an actual subscriber. I'll be fixing this issue shortly.

Thanks for the update. This will fit nicely in our v15 major update

Tim203 commented 1 year ago

This issue has been fixed in the latest build - 68