search

GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.69k stars 674 forks source link

Geyser doesn't respond to KeepAlive packets #2776

Open Tuguicraft opened 2 years ago

Tuguicraft commented 2 years ago

Describe the bug

I have got an issue with a mod called UniversalGraves, that uses a library called Polymer

As Patbox said: "Polymer adds it's own handshake thats run before proper joining (doesn't use vanilla one to stay compatible with Velocity/Bungee) It uses KeepAlive packets for initialization, which normally passes it, but Geyser doesn't respond to it, which "locks" player from joining."

What causes it.

To Reproduce

  1. Install Geyser-Fabric
  2. Install UniversalGraves.
  3. Join with a Bedrock account.

Expected behaviour

Shouldn't kick the Bedrock player with the error "Read timed out".

Screenshots / Videos

No response

Server Version and Plugins

No response

Geyser Dump

No response

Geyser Version

Geyser-Fabric-2.0.0-SNAPSHOT (git-master-222c9d7)

Minecraft: Bedrock Edition Version

No response

Additional Context

No response

Camotoy commented 2 years ago

Do you have the forward-player-ping option enabled?

Tuguicraft commented 2 years ago

Yes I have it enabled. Should I turn it off and try?

Camotoy commented 2 years ago

I have a strong feeling that disabling that setting will allow this feature to work, yes. We currently have a piece of code involving that setting that ignores negative Bedrock keep alive packets.

Tuguicraft commented 2 years ago

Yes it works! Thank you so much :)

Camotoy commented 2 years ago

Reopening as this is still a bug we should address.

HatTrkPatrk commented 1 month ago

Reopening as this is still a bug we should address.

Has this been fixed?