search

GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.59k stars 656 forks source link

Resourcepack hotloading #3143

Open TypicalShavonne opened 1 year ago

TypicalShavonne commented 1 year ago

Describe the bug

Putting a new resourcepack into packs folder while geyser is running and there is another pack already in there would cause none player able to join the server

To Reproduce

  1. Put this pack into packs folder
  2. Start geyser
  3. Overdrive the geysertestpack1.zip with this pack
  4. Join the server

Expected behaviour

Player join the server and download pack2 normally

Screenshots / Videos

image

Server Version and Plugins

[20:06:17 INFO]: Velocity 3.1.2-SNAPSHOT (git-74edac96-b153) [20:06:17 INFO]: Copyright 2018-2021 Velocity Contributors. Velocity is licensed under the terms of the GNU General Public License v3. [20:06:17 INFO]: velocitypowered.com - GitHub

Geyser Dump

No response

Geyser Version

[20:06:35 INFO]: This server is running Geyser version 2.1.0-SNAPSHOT (git-local/dev-240af3c) (Java: 1.19, Bedrock: 1.19.0/1.19.2 - 1.19.10)

Minecraft: Bedrock Edition Device/Version

1.19.10

Additional Context

I downloaded this version from jenkins branch feature/extensions latest

Kas-tle commented 1 year ago

Hot loading has (I believe) never been supported so this is more a feature request. Also I assume you meant 1.19.10 for the version?

TypicalShavonne commented 1 year ago

yea, sorry, i fixed it

Konicai commented 1 year ago

I cannot say whether or not this will be added to Geyser. However, SessionLoadResourcePacksEvent is available within the geyser api, allowing developers to choose which resource packs a client should be sent on the fly.