search

GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.72k stars 676 forks source link

PlayerInteractEvent for tablets are ALWAYS right_click_block #3276

Closed JHarris12345 closed 2 years ago

JHarris12345 commented 2 years ago

Describe the bug

When a bedrock player on tablet / phone smacks a block, the action received for the PlayerInteractEvent is always RIGHT_CLICK_BLOCK despite it should being LEFT_CLICK_BLOCK

To Reproduce

  1. Go on your iphone or tablet
  2. Have a plugin output the action for the PlayerInteractEvent OR just try to preview crates (as this uses left click block)
  3. See how when you hit a block, it fires RIGHT_CLICK_BLOCK

Expected behaviour

It should fire LEFT_CLICK_BLOCK

Screenshots / Videos

No response

Server Version and Plugins

This server is running Pufferfish version git-Pufferfish-11 (MC: 1.19) (Implementing API version 1.19-R0.1-SNAPSHOT) (Git: a593bf6 on HEAD) You are running 23 versions beyond. Please update your server when possible to maintain stability, security, and receive the latest optimizations. Previous version: git-Pufferfish-71 (MC: 1.18.2)

Geyser Dump

https://dump.geysermc.org/ApPGtgQ3jA11ONpAEX0YZ21Rn0yNxQXm

Geyser Version

Build #1188

Minecraft: Bedrock Edition Device/Version

Iphone 12

Additional Context

No response

Camotoy commented 2 years ago

I highly doubt we can do anything about this without hampering the experience for mobile. If people want to left-click on mobile then they have to hold down on the block.

JHarris12345 commented 2 years ago

Yeah sorry I didn't realise the open was hold click. This can be closed

Konicai commented 2 years ago

👍

Konicai commented 2 years ago

Why is gitthub being weird. Closing with comment just makes a comment and doesn't close it for me on safari mobile?