GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.72k stars 676 forks source link

Quick Move on Console Bedrock players from crafting menus (crafting table, stone cutter, etc) causes glitches #3361

Closed KvassBoy closed 1 year ago

KvassBoy commented 1 year ago

Describe the bug

Quick move does not fully craft the stack of one item to another when on console bedrock (confirmed on three separate bedrock consoles). It will cause item blocks to flash between the crafting UI and inventory rapidly before stopping and only 1-10 blocks crafted. Item also has a chance to change to a different item block crafted than what the player chose to craft (confirmed on stonecutter).

Splitting stacks evenly for crafting also does not work. This will cause item blocks to also flash rapidly and stacks to be uneven.

The rapidly flashing blocks also have a chance to rearrange players inventory and hot bar.

Take half also does not work at all.

To Reproduce

See “describe bug” section

see also “videos” to see it in action

make sure to use bedrock Minecraft and not java Minecraft

Happens on any device that runs bedrock

Expected behaviour

quick move crafts all items in the stack. No inventory shifts

Screenshots / Videos

https://imgur.com/a/ZL7Yfpe

Server Version and Plugins

Geyser Build #1219 (Oct 21, 2022, 7:09:38 PM)

floodgate Build #73 (Aug 10, 2022, 10:00:34 PM)

ProtocolLib 4.8.0

Geyser Dump

https://dump.geysermc.org/gPQzlNF82Ul5YC0rpdACrzVLCiwjPWyb

Geyser Version

Build #1219 (Oct 21, 2022, 7:09:38 PM)

Minecraft: Bedrock Edition Device/Version

Any device that runs bedrock on latest version

Additional Context

Attempt to determine if bug is caused by plug-in conflict Started a fresh server with only Geyser, Floodgate, and ProtocolLib installed. Bug persisted. Checked for update for all plugins, restarted server, bug persisted.

mightypandacat commented 1 year ago

I am assisting with this server testing.

seems to be a repeat of this bug here: https://github.com/GeyserMC/Geyser/issues/1601

Followed steps from Kastle in the discord, issue persists.

Tested again today.

It glitched slightly but was crafting the whole stack on bedrock. With no changes to plug-ins or server, tested again within the hour and it resumed the bug.

KvassBoy commented 1 year ago

Just tested Geyser out by itself on a freshly made server. Issue still occurs even on the latest version of Geyser.

we can confirm it isn’t anything on our end. We’ve tried everything from slowly adding and removing plugins to resetting config files to a brand new non modified fresh install and it still occurs.

mightypandacat commented 1 year ago

https://imgur.com/1JPZGM2

https://imgur.com/zzEbg9e

further testing. Glitch seems to happen with certain inventory slots occupied both for stacking and for stonecutter.

KvassBoy commented 1 year ago

We did also try to verify it wasn’t an issue on papers end so we ran the plug-in fresh install via fabric and the issue still occurred.

Can confirm it isn’t a issue from paper (which we are using to run the main server)

Please devs, confirm if this is a bug or not. We are losing sleep over this

SirFluffDev commented 1 year ago

This issue still persists for me on the latest version (updated it today). It's quite annoying.

jcurtis06 commented 1 year ago

This issue still persists for me on the latest version (updated it today). It's quite annoying.

Happens for me as well on the latest version. Seems to be related with the client inventory and Geyser inventory being out of sync (or at least, that's what I gathered from the conversation on Discord). It would be awesome if this bug could be fixed

jcurtis06 commented 1 year ago

With the latest build, crafting is practically unusable. Previously, I was able to get crafting to work by doing it “the old way”, and manually putting items in. However, even this is becoming unusable as you can no longer equally divide items in the crafting grid. On top of that, when you click to actually craft the item, it flashes around and takes forever to actually give you your item. It’s becoming extremely frustrating at this point, as survival is becoming next to unplayable for bedrock players.

KvassBoy commented 1 year ago

This issue still persists for me on the latest version (updated it today). It's quite annoying.

Happens for me as well on the latest version. Seems to be related with the client inventory and Geyser inventory being out of sync (or at least, that's what I gathered from the conversation on Discord). It would be awesome if this bug could be fixed

I wonder if there's a way we can fix it in on our phone am servers simply by changing the geyser config a little bit until the developers actually fix it?

If it is a sync issue, wouldn't it be related to a network setting?

Camotoy commented 1 year ago

We don't have a config option for anything like this.

I'll try to take a look at this tomorrow.

Camotoy commented 1 year ago

I took a look at your video with the stonecutter. That particular instance should have a solution, but it'll be a bit difficult to implement.

Will investigate crafting later.

Camotoy commented 1 year ago

Autocrafting should operate a bit better now. I was unable to replicate your issues with equally dividing items, though I haven't tried with ProtocolLib.

jcurtis06 commented 1 year ago

Autocrafting works perfectly now, thanks! I am still experiencing issues with splitting stacks (no protocol lib on my server). Maybe it's something related to the switch console? I can get a video later if you think it'd be beneficial. Personally, I don't think it's a big deal that splitting stacks doesn't work since auto crafting is fixed.

Thanks again for fixing this!

Camotoy commented 1 year ago

Thanks for being patient.

I was using a PS4 in my tests, so I would be surprised if the Switch is different, but it's not out of the question.

KvassBoy commented 1 year ago

I'm still experiencing issues on the stone crafter and have yet to test out the actual autocrafter yet. I might be my current ping so will attempt to test it with the latest version of all plugins tonight!

Camotoy commented 1 year ago

I would not expect the stonecutter to be fixed. It can be fixed, but it'll take some time.

KvassBoy commented 1 year ago

Understandable. The stonecutter stills works fine as long as users craft slowly which I'm sure is fine for most users

Will test out autocraft on my server tonight and see what happens!

KvassBoy commented 1 year ago

Tested it out today. It's much better. I was able to craft items on the crafting table fine. I did notice you have to leave the crafting table for it to show everything in inventory sometimes but otherwise it's useable again!

Thank you!

adit4rt commented 1 year ago

this problem is also happening now on my server, the glitch that interferes with crafting is really annoying. even i am already using latest version but still it happens.

onebeastchris commented 1 year ago

A recent version fixed shift clicking of some items - could you retest to see what is still affected?

onebeastchris commented 1 year ago

Closing this issue due to no response. If you still experience the issue you described here, please open a new issue with updated information, like a Geyser dump and reproduction steps.