GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.69k stars 674 forks source link

Rejecting UseItemOnPacket (Folia) #3663

Closed Yomamaeatstoes closed 1 year ago

Yomamaeatstoes commented 1 year ago

Describe the bug

The bug creates a bunch of error messages in the console, and I don't know if it has any impact on performance but playing Bedrock on Folia is super laggy so far. [04.04 08:07:48] [Server] [WARN] Rejecting UseItemOnPacket from 5074pokemon: Location (5586.690317988396, 104.0, -4803.476047098637) too far away from hit block It sounds like it is triggered by hitting a block, but it is hard to know.

To Reproduce

Go on Folia Hit a block Massive lag Error message

Expected behaviour

No error message and no massive lag spike

Screenshots / Videos

Bedrock to Folia

https://youtu.be/oWt4eR_ke7A


Bedrock to Paper

https://youtu.be/V1rIowHUKTY

Server Version and Plugins

Region Scheduler Thread (x1)0.00% Other The following other plugins are installed, but didn't show up in this profile. Yay!

ViaVersion (v4.7.0-23w13a-SNAPSHOT) floodgate (v2.2.2-SNAPSHOT (b??-2702bc3)) ViaBackwards (v4.7.0-23w13a-SNAPSHOT) Geyser-Spigot (v2.1.0-SNAPSHOT) ViaRewind (v2.0.4-SNAPSHOT) Spartan (vPhase 502) Chunky (v1.3.70) BetterEconomy (v2.12)

This server is running Geyser version 2.1.0-SNAPSHOT (git-master-0f99abc) (Java: 1.19.4, Bedrock: 1.19.30/1.19.31 - 1.19.70/1.19.71)

Geyser Dump

https://dump.geysermc.org/ppIMzW41VlRR0fllolSRxyDpWd01mm9H

Geyser Version

Geyser version 2.1.0-SNAPSHOT (git-master-0f99abc)

Minecraft: Bedrock Edition Device/Version

Windows and presumably every version

Additional Context

None, I reference this error in the development page.

Full error

:07:34] [Server] [INFO] There are 4 of a max of 10000 players online: nucklear, .nucklear_reaper, 5074pokemon, .spitan [04.04 08:07:48] [Server] [WARN] Rejecting UseItemOnPacket from 5074pokemon: Location (5586.690317988396, 104.0, -4803.476047098637) too far away from hit block BlockPosition{x=5585, y=103, z=-4804}. [04.04 08:07:49] [Server] [WARN] Rejecting UseItemOnPacket from 5074pokemon: Location (5586.690317988396, 104.0, -4803.476047098637) too far away from hit block BlockPosition{x=5585, y=103, z=-4804}. [04.04 08:07:49] [Server] [WARN] Rejecting UseItemOnPacket from 5074pokemon: Location (5586.690317988396, 104.0, -4803.476047098637) too far away from hit block BlockPosition{x=5585, y=103, z=-4804}. [04.04 08:07:54] [Server] [WARN] Rejecting UseItemOnPacket from 5074pokemon: Location (5584.713971853256, 104.0, -4803.536168217659) too far away from hit block BlockPosition{x=5583, y=103, z=-4804}. [04.04 08:07:55] [Server] [WARN] Rejecting UseItemOnPacket from 5074pokemon: Location (5584.640117049217, 104.0, -4803.536168217659) too far away from hit block BlockPosition{x=5583, y=103, z=-4804}. [04.04 08:07:55] [Server] [WARN] Rejecting UseItemOnPacket from 5074pokemon: Location (5584.640117049217, 104.0, -4803.536168217659) too far away from hit block BlockPosition{x=5583, y=103, z=-4804}. [04.04 08:07:55] [Server] [WARN] Rejecting UseItemOnPacket from 5074pokemon: Location (5584.610722661018, 104.0, -4803.5367403924465) too far away from hit block BlockPosition{x=5583, y=103, z=-4804}. [04.04 08:07:55] [Server] [WARN] Rejecting UseItemOnPacket from 5074pokemon: Location (5584.610722661018, 104.0, -4803.5367403924465) too far away from hit block BlockPosition{x=5583, y=103, z=-4804}. [04.04 08:07:56] [Server] [INFO] [Geyser-Spigot] spitan has disconnected from the Java server because of Bedrock client disconnected

https://spark.lucko.me/2FYb5tFX4d

Kas-tle commented 1 year ago

Are you using any datapacks?

Yomamaeatstoes commented 1 year ago

Are you using any datapacks?

I am not using any DataPacks

Camotoy commented 1 year ago

I'll have to look into the code to see if Folia changes anything, but I almost wonder if this is some sort of bug on their end...

Camotoy commented 1 year ago

Also, try without Spartan since that's an anticheat.

Yomamaeatstoes commented 1 year ago

Also, try without Spartan since that's an anticheat.

Ok I can try that and I will get back to you. I don't know if it makes a difference, but Spartan is disabled because they failed to properly port it to Folia. https://mclo.gs/PjNwK34

Yomamaeatstoes commented 1 year ago

@Camotoy and @Kas-tle You were right. It was the anti cheat spartan that caused this issue. Once I removed it I did not get these issues.

Yomamaeatstoes commented 1 year ago

Spartan seems like it caused it? No conclusive answers