GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.69k stars 674 forks source link

Bedrock clients lag and holo items drop #3732

Open Leahcimkrob opened 1 year ago

Leahcimkrob commented 1 year ago

Describe the bug

Can anyone tell why holographic items on all Bedrock clients fall down when they are in sight and then laggs occur? Until a few weeks ago it was only like this with Playstation, now with all Bedrock clients. According to the Quickshop dev, the plugin works with Virtual Hologram items, not Armorstands

To Reproduce

Login with Bedrock Teleport to a Shop-Region Holo-Items will drop

Expected behaviour

I expected that a Bedrock user would teleport to our shop and be able to shop there without any problems.

Screenshots / Videos

https://user-images.githubusercontent.com/70509359/235411996-1e5d17d4-c50c-44ae-a67a-203b50043346.mp4

Server Version and Plugins

This server is running Paper version git-Paper-514 (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT) (Git: dd216c1) Plugins: AdvancedDropManager 3.0.7-SNAPSHOT AdvancedRegionMarket 3.4.3 AdventureCalendar 1.7 AntiMapCopy 2.4 antiRedstoneClock 1.4.1 ArmorStandTools 4.4.4 Automessage 1.2 Bank 4.6.2-RELEASE BankPlus 5.7 BCommons 0.3.0 BigDoors Alpha 0.1.8.45 (b1134) Booster 8.6 BottledExp 3.1.3.1 Builders-Utilities 2.1.1-80 BungeeTokens-Spigot 1.1-SNAPSHOT ChatFeelings 4.11.1 ChatFree 1.2 ChestCommands 4.0.3 Citizens 2.0.31-SNAPSHOT (build 3037) ClearLag 3.2.2 CMI 9.5.0.8 CMILib 1.2.5.3 Core 0.5.8 CoreProtect 21.3 CraftingStore 2.9.0 Craftmatic 3.1.0 CrashAPI 1.1.4 CrazyCrates 1.11.14.3 DeathCoordinates 1.12.1 DisableChorusFruit 1.3.0 Elevator 1.3-SNAPSHOT EmployMe 1.1.0 EnchantmentSolution 2.5.6 EpicFurnaces 4.9.7-BETA EpicSign 2.0.3 EscoVotifier-Spigot 1.0-SNAPSHOT Ethria-Board 1.0-SNAPSHOT Ethria-Common 1.0-SNAPSHOT Ethria-Perks 1.0-SNAPSHOT EthriaEvent 1.0-SNAPSHOT FastAsyncWorldEdit 2.6.0-SNAPSHOT-402;86acb1c ForceField 1.1.0 GPet 1.1.4 GSit 1.4.4 HeadBlocks 2.2.5 HeadDatabase 4.17.0 HiddenArmor 1.1.0 HolographicDisplays 3.0.2-SNAPSHOT-b251 HuskHomes 4.2.1 HuskHomesGUI 2.2 ImageMaps 1.0.10 iShop 2.22 ItemSorter 1.4.1_DEV Jobs 5.1.2.2 KixsChatGames 2.0.4 Lottery 1.4.6 LuckPerms 5.4.58 MarriageMaster 2.6.15 mcMMO 2.1.219 MobsToEggs 1.7.1 Multiverse-Core 4.3.2-SNAPSHOT-b870 MysqlPlayerDataBridge 4.8.1 NametagEdit 4.5.16 NBTAPI 2.11.2 NotQuests 5.14.0 PlaceholderAPI 2.11.3 PlayerWarps 6.23.1 PlotBorders 1.9 PlotSquared 6.11.1-Premium PluginManager 2.7.4 PreventMapCloning 1.0-SNAPSHOT ProtocolLib 5.0.0-SNAPSHOT-636 QuickShop 5.1.2.1-SNAPSHOT RankUpgrade 1.0-SNAPSHOT RedLib 2022-09-25 01:04 Signatures 1.0 SmileCore 1.1.1-SNAPSHOT spark 1.10.34 StackMob 5.8.5 Stopwatch 1.0 TAB-Bridge 2.0.11 UltimateAutoRestart Build 53 UltimateBackPack 2.7.1 UltimateClans 5.10.3 UltimateSign 1.5.2 UltimateTimber 2.3.6 Vault 1.7.3-CMI Votifier 2.7.1 Werbung 1.0-SNAPSHOT WorldGuard 7.0.8-SNAPSHOT+2200-4a21bf4

Geyser Dump

https://dump.geysermc.org/RmqFgLoPqHyx91koUZTDkrd1PQlQV7KD

Geyser Version

1352

Minecraft: Bedrock Edition Device/Version

1.19.81 - Windows 11, Android, Playstation 4, Playstation 5 .....

Additional Context

No response

onebeastchris commented 1 year ago

Hey! Could you try the latest Geyser build and see if the error persists? It could be unrelated; but not necessarily - please try updating Geyser. Thanks!

Leahcimkrob commented 1 year ago

Hello, since the last builds seem to bring errors during the test and it is also constantly written in the Discord support chat that there are problems with the login afterwards, I'm waiting for a clean build first. The problem has also existed for a long time and if you go through your issues after lagg or hologram, it's not just since the 1352

onebeastchris commented 1 year ago

The latest build is an attempt to fix some/all of the errors; please update and try the build.

If you keep getting errors, send a new Geyser dump, and logs. For the geyser dump, run "geyser dump" in the server console & send the link you get here. For the logs, upload your latest.log file from the logs folder to mclo.gs and send the link here.

Leahcimkrob commented 1 year ago

I'll try it as soon as there are fewer people on our server

Leahcimkrob commented 1 year ago

Same issue. https://dump.geysermc.org/k9UcZ1FmEAW1V2BNfSITAHJl0vjp1fm8

Bungee-Log: https://mclo.gs/I3C3QI7

Paper-Log: https://mclo.gs/pm2pStU

onebeastchris commented 1 year ago

The dump you sent indicates that you aren't on the latest version of Geyser.

Leahcimkrob commented 1 year ago

I downloaded Dev 1361 this morning and restarted the server with it. This morning it was the current build. Ich habe die Version hier runter geladen: https://ci.opencollab.dev//job/GeyserMC/job/Geyser/job/master/

onebeastchris commented 1 year ago

Did you re-run the geyser dump command? It shows that you're 7 commits behind.. If it's not the latest Geyser dump, send a new one

Leahcimkrob commented 1 year ago

https://dump.geysermc.org/1TwmOFC5sCd7Ug9hucm6pMHiIvnUK2az

onebeastchris commented 1 year ago

https://geysermc.org/utilities/dump_viewer#1TwmOFC5sCd7Ug9hucm6pMHiIvnUK2az This dump too shows that you're running build 1354. Please make sure to update properly by:

Leahcimkrob commented 1 year ago

There comes the same. I decompiled the geyser-bungeecord.jar and there I can see in the git.properties file that the wrong build number is entered in the 1362 build. Same in Build 1359

onebeastchris commented 1 year ago

I cannot reproduce that. Just downloaded build 1361 from Jenkins, and the build number is correctly set in git.properties - the only reason you wouldn't be getting the right build number would be if it's not the newest jar. Did you download the latest build?

Alternatively, download Geyser from the new downloads website; geysermc.org/download - those builds are uploads from builds by GitHub actions.

Leahcimkrob commented 1 year ago

I downloaded it and made a video of it.

https://user-images.githubusercontent.com/70509359/235688657-430d9284-ea87-4cd8-aebd-b15ccabb5d2c.mp4

Leahcimkrob commented 1 year ago

geysermc.org/download Then I get the version:

git.branch=master git.build.number=-1 git.build.version=2.1.0-SNAPSHOT git.commit.id=b48d4a0625ed9a269d81fea6e535345bce01c0af git.commit.id.abbrev=b48d4a0 git.commit.message.full= git.remote.origin.url=https://github.com/GeyserMC/Geyser

onebeastchris commented 1 year ago

Seems like you're trying to download the latest successful artifact, which is a few builds ago, instead of the newest one by selecting the newest build manually - it's an issue on our side, but you can get the latest if you click the on the latest version number. Or, avoid the issues with our CI entirely by downloading from our downloads page.

Leahcimkrob commented 1 year ago

From your downloadpage, I get this git.build.version=2.1.0-SNAPSHOT

onebeastchris commented 1 year ago

That's good; as for the build number being -1 there, that'll be addressed. You can verify it's the latest using the commit id.

Leahcimkrob commented 1 year ago

Ok, he only ever downloaded the last successful build, not the actual one.

Leahcimkrob commented 1 year ago

same issue with 1365 https://dump.geysermc.org/BKTYe3eq5tnlhBGW2iUWD7fCubna8XWt

Bungee-Log: https://mclo.gs/ylV4ESl

Server-Log: https://mclo.gs/h4xBeNH

onebeastchris commented 1 year ago

Unfortunately, due to amount of plugins, debugging this isn't feasible. Could you please narrow down the plugin that introduces/causes the "halo items dropping"? That would allow us to fix that specific bug.

Leahcimkrob commented 1 year ago

It's all plugins that use holographic items. In our case, we only had QuickShop Reremake on it. Now we have switched to the QUickshop Hikari. but no matter if we use the holoitems with armorstands or virtual, it leads to laggs with bedrockclients