search

GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.72k stars 676 forks source link

Bedrock-Issue with close-event #3932

Open Leahcimkrob opened 1 year ago

Leahcimkrob commented 1 year ago

Describe the bug

Hello, I have a problem with our Bedrock players and the Autocrafter plugin. Normally you can insert a recipe with the autocrafter and he will then create the items himself according to the recipe. Unfortunately, the Bedrock players cannot insert a recipe. As soon as you close the GUI, you get the items from the GUI in your inventory and the autocrafter is empty or no longer has a recipe. It's been like this since 1.20, or wasn't noticed before. Did you do anything at the close event to make it go like this? The question comes from the Autocrafter dev.

I have included his statement with a link to the plugin and his spigot page as a link so that you can read it.

greeting Michael

https://paste.gg/p/Bloody_Mind/652fbfdab25d4c43a027c0f55a23f158

To Reproduce

open workbench from autocrafter place items like 9 diamonds close workbench

Expected behaviour

As soon as you close the GUI, you get the items from the GUI in your inventory and the autocrafter is empty or no longer has a recipe

Screenshots / Videos

No response

Server Version and Plugins

/version [19:01:49 INFO]: Checking version, please wait... [19:01:49 INFO]: This server is running Paper version git-Paper-58 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 225c950) You are 3 version(s) behind Download the new version at: https://papermc.io/downloads/paper Previous version: git-Paper-54 (MC: 1.20.1)

Geyser Dump

https://dump.geysermc.org/qjRoUL0IhxXV2zUPs3dobi11dXbdcfHu

Geyser Version

Geyser-BungeeCord-1433

Minecraft: Bedrock Edition Device/Version

all Bedrock-Clients

Additional Context

No response

paul-palmer commented 1 year ago

The autocrafting plugin creates and opens a workbench inventory view using openWorkbench (https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/HumanEntity.html#openWorkbench(org.bukkit.Location,boolean)) with a location set and force set to true. When the player closes the workbench view, an InventoryClose event is generated. However, neither the recipe nor the ingredients are set in the event.

onebeastchris commented 7 months ago

oops; replied on the wrong issue - going to look into this now though.