GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.73k stars 681 forks source link

1.20.30 - Missing "Render Dragon Features for creators" Toggle #4123

Open rad1914 opened 1 year ago

rad1914 commented 1 year ago

Describe the bug

Hey everyone! I'm planning to set up an SMP server with my friends. I noticed that Geyser now works with Bedrock version 1.20.30, which also supports Minecraft Deferred rendering. But, As far as I know, to activate that option, you need to enable "Render Dragon features for creators" in the experimental toggles section. I know Java doesn't have these functions, so I thought I'd ask for some help..

Does anyone have any ideas on how to make the Bedrock client believe that this option is turned on, so we can use this new feature for all server owners?

I'd appreciate any assistance with this.

To Reproduce

  1. Install Minecraft Bedrock 1.20.30.
  2. Install a resource pack for Geyser that supports Deferred rendering.
  3. Look for the video option in Minecraft Bedrock settings in-game.
  4. Oops, missing option because the experimental toggles are disabled:p

Expected behaviour

Enable deferred rendering properly.

Screenshots / Videos

Screenshot_20230916-105407_Minecraft Preview (Patch)

Server Version and Plugins

Current: git-Purpur-2057 (MC: 1.20.1)*

Geyser Dump

https://dump.geysermc.org/uActAE56zj8xFETHyzpUzxckWjQyjJC4

Geyser Version

[10:51:58 INFO]: This server is running Geyser version 2.2.0-SNAPSHOT (git-master-69f89ed) (Java: 1.20, Bedrock: 1.20.0/1.20.1 - 1.20.30).

Minecraft: Bedrock Edition Device/Version

1.20.30 Bedrock Win10/1.20.30 Mcpe (Android)

Additional Context

No response

onebeastchris commented 1 year ago

Considering the issue is very new, and a tad unstable (as seen in e.g. the bug fixes related to this in the 1.20.40 preview changelogs: https://feedback.minecraft.net/hc/en-us/articles/19648957981965-Minecraft-Beta-Preview-1-20-40-22), this is unlikely to be added at the given point in time. We can probably add it, although I'd imagine we wouldn't for now - not up to me though.

If you wish to add it manually, you could try to edit the experiments Geyser sends to Bedrock clients when joining in a custom fork - feel free to reach out in the #dev-general channel for help with that.

rad1914 commented 1 year ago

Yes, creating a fork of Geyser that sends experimental switch packets is the best idea I came up with. The issue is, I'm not a developer and don't know much about Geyser development, but with the missing implementation label, maybe someone can help us out!:D