search

GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.71k stars 675 forks source link

Getting "An exceptionCaught() event was fired.... Index 0 out of bounds for length 0.." on velocity With MiniMOTD plugin and MOTD pass through enabled #4223

Closed c00ldude1oo closed 11 months ago

c00ldude1oo commented 11 months ago

Describe the bug

I just swapped to velocity from waterfall, and I am getting this error as soon as velocity finishes starting. It happens every minute or so to every other second. When a bedrock player is online, it sends it every 5-10 sec

after adding and removing plugins, i found that when having minimodt and geyser installed is when it happens

[11:45:53] [epollEventLoopGroup-7-1/WARN] [io.netty.channel.DefaultChannelPipeline]: An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
    at org.geysermc.geyser.network.netty.GeyserServer.onQuery(GeyserServer.java:246) ~[?:?]
    at org.geysermc.geyser.network.netty.handler.RakPingHandler.channelRead0(RakPingHandler.java:48) ~[?:?]
    at org.geysermc.geyser.network.netty.handler.RakPingHandler.channelRead0(RakPingHandler.java:37) ~[?:?]
    at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.onUnconnectedPing(RakServerOfflineHandler.java:112) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.channelRead0(RakServerOfflineHandler.java:96) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.channelRead0(RakServerOfflineHandler.java:43) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.AdvancedChannelInboundHandler.channelRead(AdvancedChannelInboundHandler.java:45) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.geysermc.geyser.network.netty.handler.RakConnectionRequestHandler.channelRead(RakConnectionRequestHandler.java:80) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.cloudburstmc.netty.handler.codec.raknet.ProxyInboundRouter.channelRead(ProxyInboundRouter.java:66) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.processPacket(EpollDatagramChannel.java:662) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.recvmsg(EpollDatagramChannel.java:697) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.access$300(EpollDatagramChannel.java:56) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel$EpollDatagramChannelUnsafe.epollInReady(EpollDatagramChannel.java:536) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:509) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:407) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at java.lang.Thread.run(Thread.java:833) [?:?]

To Reproduce

Start server

Expected behaviour

no error

Screenshots / Videos

No response

Server Version and Plugins

Velocity 3.2.0-SNAPSHOT (git-81b183ac-b276)

floodgate 2.2.2-SNAPSHOT (b85-71acc6c)

Geyser-Velocity 2.2.0-SNAPSHOT (git-master-6b67e43)

MiniMOTD 2.0.14

PlasmoVoice 2.0.7

pv-addon-groups 1.0.3

spark 1.10.55

Geyser Dump

https://dump.geysermc.org/dwYWMtaCC04O6FUw90VR9IKB77G0T9kO

Geyser Version

2.2.0-SNAPSHOT (git-master-6b67e43)

Minecraft: Bedrock Edition Device/Version

No response

Additional Context

It does not happen with geyser and flood gate removed

and it doesn't happen with just floodgate & geyser

c00ldude1oo commented 11 months ago

The console also gives these warnings when floodgate is installed with or without geyser

[16:30:24 WARN]: The server channel initializer has been replaced by java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[16:30:24 WARN]: The backend channel initializer has been replaced by java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Kas-tle commented 11 months ago

Please try without the voice plugins.

c00ldude1oo commented 11 months ago

Please try without the voice plugin.

Just updated main post.

It is only when having minimodt and geyser installed that it happens

Kas-tle commented 11 months ago

In that case try disabling MOTD pass through in the Geyser config.

Kas-tle commented 11 months ago

Ok, so it's the voice plugin. Probably won't happen with ping-passthrough disabled.

c00ldude1oo commented 11 months ago

I disabled the MOTD pass-through, no errors show up when adding back minimotd like before.

onebeastchris commented 11 months ago

Is your MOTD empty by chance? If yes, i could see this failing due to the split() function returning an empty array.

c00ldude1oo commented 11 months ago

Ok I checked and technical yes it is empty. I am using the virtual-hosts feature and I have set the default/main to be empty.

I changed the default/main to be a test string and re-enabled motd-passthrough, and it has no errors and MC win10 shows the test string as the MOTD

set the MOTD back to "" and left motd-passthrough on and the errors show up again

onebeastchris commented 11 months ago

Thanks for testing :) Once https://github.com/GeyserMC/Geyser/pull/4259 builds, can you try using the Geyser-Velocity artifact found under "Checks" and see if that resolves the issue?

c00ldude1oo commented 11 months ago

downloaded it, turned on motd-passthrough, restarted annd..

[04:23:19] [epollEventLoopGroup-7-1/WARN] [io.netty.channel.DefaultChannelPipeline]: An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
java.lang.IllegalStateException: null
    at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?]
    at org.geysermc.geyser.platform.velocity.GeyserVelocityPingPassthrough.getPingInformation(GeyserVelocityPingPassthrough.java:60) ~[?:?]
    at org.geysermc.geyser.network.netty.GeyserServer.onQuery(GeyserServer.java:233) ~[?:?]
    at org.geysermc.geyser.network.netty.handler.RakPingHandler.channelRead0(RakPingHandler.java:48) ~[?:?]
    at org.geysermc.geyser.network.netty.handler.RakPingHandler.channelRead0(RakPingHandler.java:37) ~[?:?]
    at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.onUnconnectedPing(RakServerOfflineHandler.java:112) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.channelRead0(RakServerOfflineHandler.java:96) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.channelRead0(RakServerOfflineHandler.java:43) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.AdvancedChannelInboundHandler.channelRead(AdvancedChannelInboundHandler.java:45) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.geysermc.geyser.network.netty.handler.RakConnectionRequestHandler.channelRead(RakConnectionRequestHandler.java:80) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.cloudburstmc.netty.handler.codec.raknet.ProxyInboundRouter.channelRead(ProxyInboundRouter.java:66) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.processPacket(EpollDatagramChannel.java:662) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.recvmsg(EpollDatagramChannel.java:697) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.access$300(EpollDatagramChannel.java:56) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel$EpollDatagramChannelUnsafe.epollInReady(EpollDatagramChannel.java:536) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:509) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:407) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at java.lang.Thread.run(Thread.java:840) [?:?]

version 2.2.0-SNAPSHOT (git-DEV-6189957)

onebeastchris commented 11 months ago

Is minimotd trying to hide player counts or similar? That's the only way i can really explain this one

c00ldude1oo commented 11 months ago

Yes… yes, it is. I just changed the config to do that as well XD. A fix for that would be nice.

Changed it back and got this.

[04:37:48] [Velocity Async Event Executor - #0/INFO] [geyser]: Done (19.664s)! Run /geyser help for help!
[04:37:50] [epollEventLoopGroup-7-1/WARN] [io.netty.channel.DefaultChannelPipeline]: An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 0
    at org.geysermc.geyser.network.netty.GeyserServer.onQuery(GeyserServer.java:249) ~[?:?]
    at org.geysermc.geyser.network.netty.handler.RakPingHandler.channelRead0(RakPingHandler.java:48) ~[?:?]
    at org.geysermc.geyser.network.netty.handler.RakPingHandler.channelRead0(RakPingHandler.java:37) ~[?:?]
    at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.onUnconnectedPing(RakServerOfflineHandler.java:112) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.channelRead0(RakServerOfflineHandler.java:96) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.channelRead0(RakServerOfflineHandler.java:43) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.AdvancedChannelInboundHandler.channelRead(AdvancedChannelInboundHandler.java:45) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.geysermc.geyser.network.netty.handler.RakConnectionRequestHandler.channelRead(RakConnectionRequestHandler.java:80) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.cloudburstmc.netty.handler.codec.raknet.ProxyInboundRouter.channelRead(ProxyInboundRouter.java:66) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.processPacket(EpollDatagramChannel.java:662) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.recvmsg(EpollDatagramChannel.java:697) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.access$300(EpollDatagramChannel.java:56) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel$EpollDatagramChannelUnsafe.epollInReady(EpollDatagramChannel.java:536) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:509) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:407) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at java.lang.Thread.run(Thread.java:840) [?:?]
onebeastchris commented 11 months ago

Pushed a new commit to the PR, please try that one once it builds. Should fix this issue, and fallback to bogus values (max 1, online players 0) when e.g. MiniMOTD is hiding player counts

c00ldude1oo commented 11 months ago

No errors when using motd-passthrough now. When turning on hide-player-count in minimotd get this error.

[05:03:40] [Velocity Async Event Executor - #0/INFO] [geyser]: Done (17.156s)! Run /geyser help for help!
[05:03:41] [epollEventLoopGroup-7-1/WARN] [io.netty.channel.DefaultChannelPipeline]: An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
java.util.NoSuchElementException: No value present
    at java.util.Optional.get(Optional.java:143) ~[?:?]
    at org.geysermc.geyser.platform.velocity.GeyserVelocityPingPassthrough.getPingInformation(GeyserVelocityPingPassthrough.java:78) ~[?:?]
    at org.geysermc.geyser.network.netty.GeyserServer.onQuery(GeyserServer.java:233) ~[?:?]
    at org.geysermc.geyser.network.netty.handler.RakPingHandler.channelRead0(RakPingHandler.java:48) ~[?:?]
    at org.geysermc.geyser.network.netty.handler.RakPingHandler.channelRead0(RakPingHandler.java:37) ~[?:?]
    at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.onUnconnectedPing(RakServerOfflineHandler.java:112) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.channelRead0(RakServerOfflineHandler.java:96) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.server.RakServerOfflineHandler.channelRead0(RakServerOfflineHandler.java:43) ~[?:?]
    at org.cloudburstmc.netty.handler.codec.raknet.AdvancedChannelInboundHandler.channelRead(AdvancedChannelInboundHandler.java:45) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.geysermc.geyser.network.netty.handler.RakConnectionRequestHandler.channelRead(RakConnectionRequestHandler.java:80) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at org.cloudburstmc.netty.handler.codec.raknet.ProxyInboundRouter.channelRead(ProxyInboundRouter.java:66) ~[?:?]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.processPacket(EpollDatagramChannel.java:662) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.recvmsg(EpollDatagramChannel.java:697) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel.access$300(EpollDatagramChannel.java:56) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollDatagramChannel$EpollDatagramChannelUnsafe.epollInReady(EpollDatagramChannel.java:536) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:509) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:407) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[velocity-3.2.0-SNAPSHOT-276.jar:3.2.0-SNAPSHOT (git-81b183ac-b276)]
    at java.lang.Thread.run(Thread.java:840) [?:?]

also love the commit naming :D

onebeastchris commented 11 months ago

fixed that one already here, wait for the new build pls

c00ldude1oo commented 11 months ago

yea, just looked and saw you did. Just downloaded and no errors 👍

onebeastchris commented 11 months ago

excellent; thanks for testing.

c00ldude1oo commented 11 months ago

NP. is it safe to use this build till next release or?

onebeastchris commented 11 months ago

Sure, you can do that for now. Once the PR is merged, you should start using the main builds found on https://geysermc.org/download though :)