search

GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.75k stars 686 forks source link

bedrock players can use any head in a villager trade #4389

Closed ckwastaken closed 8 months ago

ckwastaken commented 10 months ago

Describe the bug

image in a trade like this one in a custom villager, on java editon you can only use that spefic player head specified in the trade to do the trade, but on bedrock any player head can be used

To Reproduce

make a trade using a custom villager trades plugin that has a custom player head as the thing you give go on bedrock editon and you will be able to trade any head to the villager

Expected behaviour

on bedrock edtion it should only let you use the spefic custom head specifed in the trade

Screenshots / Videos

this works on java (intended): image

this dosent work on java (intended): image

on bedrock:

the intended trade works: image

however any other head will also work (not intended): image image

Server Version and Plugins

No response

Geyser Dump

https://dump.geysermc.org/yveYM7AiHm3o348CqiDmEkilCGAuslkR

Geyser Version

2.2.0-SNAPSHOT (git master 7613bdb)

Minecraft: Bedrock Edition Device/Version

v1.20.51

Additional Context

No response

Kas-tle commented 8 months ago

I cannot reproduce this at all, but rather I find that Geyser in this case does not allow the trade to go through even when the correct skull is used, which would be a duplicate of https://github.com/GeyserMC/Geyser/issues/4092. If you can still reproduce this, please provide the command to spawn such a villager with this issue and I will reopen.