search

GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.75k stars 686 forks source link

Not using logger when configuration parsing fails #4571

Open rtm516 opened 7 months ago

rtm516 commented 7 months ago

When this fails it calls the built in system error log instead of using our logger so on plugin versions it warns about using the plugin logger.

https://github.com/GeyserMC/Geyser/blob/a24f68412315fdabe93053d7722f9c9f15fc6511/core/src/main/java/org/geysermc/geyser/configuration/GeyserJacksonConfiguration.java#L354

onebeastchris commented 7 months ago

The geyser logger isn't constructed until after the config is read though, so we can't simply switch it out

onebeastchris commented 5 months ago

oops, this ain't fixed yet - maybe with the config rewrite :p But the linked PR does ensure that the geyser logger is always available so we don't need to use system.out.printl()