GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.69k stars 674 forks source link

[Geyser-Spigot] Missing locale: de_CH (Commit 0fcf0f9) #4725

Open SebastianHenzmann opened 3 months ago

SebastianHenzmann commented 3 months ago

Describe the bug

Missing locale: de_CH Warning starting with commit 0fcf0f9.

In the Config.yml file, the default locale is commented out, but this has never caused any issues.

The default locale if we dont have the one the client requested. Uncomment to not use the default system language.

default-locale: en_us

Adding a default locale e.g. de_de still results in Missing locale: de_CH

To Reproduce

Windows default language Deutsch (Schweiz) Create Paper Server using latest jar file Add GeyserMC for spigot (Commit 0fcf0f9 or newer) to plugins folder Start Server

Expected behaviour

Console output contains: [16:17:29 WARN]: [Geyser-Spigot] Missing locale: de_CH

Screenshots / Videos

image

Server Version and Plugins

No response

Geyser Dump

No response

Geyser Version

Geyser Version 2.3.1-SNAPSHOT (git-master-0fcf0f9)

Minecraft: Bedrock Edition Device/Version

No response

Additional Context

No response

onebeastchris commented 3 months ago

Changing the default locale in the configuration unfortunately won't prevent that warning, as the default locale in the config is loaded after we load the system locale (and then overriden).

The warning isn't strictly relevant and can be ignored, but it would make sense for us to fallback to the closest similar locale (here, de_DE)