GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.69k stars 674 forks source link

Cant craft dispensers in crafting table. #4865

Closed Jsaunders411 closed 1 month ago

Jsaunders411 commented 1 month ago

Describe the bug

Cant craft dispensers by clicking picture in crafting table. even if you have all the needed items on you to craft it still shows red and only able to craft it by manually putting it in the crafting table and crafting it.

To Reproduce

Go to crafting table with needed items to craft dispenser in your inventory. Look for dispenser in crafting table pictures. They will show red and uncraftable. Manually put its in crafting square then you can craft it by clicking the item next to the crafting grid it will work. If you select it from known recipes in the book it will go back to red and not craft able.

Expected behaviour

Have items in your inventory for dispenser and be able to click recipe in book and craft it.

Screenshots / Videos

No response

Server Version and Plugins

No response

Geyser Dump

No response

Geyser Version

Geyser 1.21 build 606

Minecraft: Bedrock Edition Device/Version

Minecraft bedrock

Additional Context

No response

onebeastchris commented 1 month ago

Hey, could you try updating Geyser and testing whether the issue persists? Thanks :)

Jsaunders411 commented 1 month ago

Hey, could you try updating Geyser and testing whether the issue persists? Thanks :)

Jsaunders411 commented 1 month ago

It was still persisting with an update with build 609 . But i will try agian with 611 tomorrow and let you know.

Jsaunders411 commented 1 month ago

Nope still persists in updated geyser build 7-17-611 can have all items in inventory click on dispenser in book it then unselects it and goes to dropper and acts like you dont have the needed items and goes red and not craftable. Unless you mainly place the items in the grid and then manually craft it one at at time.

onebeastchris commented 1 month ago

Please send a screenshot of the issue - further, please make sure that you have the dispenser crafting recipe unlocked

Jsaunders411 commented 1 month ago

20240718_135729

Jsaunders411 commented 1 month ago

Crafting recipe is unlocked as i have manually crafted many dispensers. Just would really like to go back to just being able to click on the recipe and craft multiple also noticing some other crafting glitches occurring with stone cutter miss crafting stairs into walls and walls into stairs. Blocks like polished adesite stairs come out as items other than stairs so maybe its linked in some way was not happening from older builds before 600 or so.

onebeastchris commented 1 month ago

What's the output of geyser version in the server console?

Jsaunders411 commented 1 month ago

Screenshot_20240718_222101_Chrome

Jsaunders411 commented 1 month ago

Running the current build been updated each time new comes out to see if it would change anything.

onebeastchris commented 1 month ago

Could you list all recipes that still seem to be broken? I'll take a more detailed look tomorrow; although I would've thought that the latest fix should've addressed these crafting issues.. odd

Jsaunders411 commented 1 month ago

Polished andesite stairs come out as slabs,cobbled deepslate stairs come out as deep slate walls,brick stairs come out as slabs for stone cutter. Are the ones if noticed so far. Its not game breaking by any means just slightly annoying when i go to craft a large stack of something and it outputs different then what i clicked lol.

Jsaunders411 commented 1 month ago

I just didn't post that bug because i saw another one about it and generally try to avoid reporting a duplicate of another bug report.

Camotoy commented 1 month ago

Can you send a Geyser dump while you're on the server? Thanks.

Jsaunders411 commented 1 month ago

https://dump.geysermc.org/iigJfmulW3exOjyzUqNdQz3FXpgW9a46

Camotoy commented 1 month ago

Were you online when you made this dump?

Jsaunders411 commented 1 month ago

https://dump.geysermc.org/slPtyZBYCktI2ntS5iYdNxjivJWCmh5p

Sorry copied the wrong link.

Jsaunders411 commented 1 month ago

This dump was while im online.

Jsaunders411 commented 1 month ago

Update on issue it seems the issue is only a problem with custom recipes data packs. upon removing master cutter data pack it clears the issue with with any customs added it causes geyser clients to have issues with stone cutter crafting. Java clients are not effected. But thats only for the stone cutter thing dispenser still effected even with just running only paper geyser and flood gate and all plugins and data packs removed.

onebeastchris commented 1 month ago

I've tried testing this on various devices, and i just cannot reproduce it. Hence, ive made a little debug build to see what recipes are being sent to the client - please download and use the build found here and send a log once you see the huge packet being printed (you can use https://mclo.gs/ to share logs easily)

Jsaunders411 commented 1 month ago

Ok so going thru and testing it only happens when i have a custom stone cutter data pack installed master cutter data pack. Removing it clears the issues with dispenser and the issue with the stone cutter out out being off for certain blocks. Was working fine up until the new 1.21 builds so not sure if its on geysers end or just a data pack issue. But the data pack was updated to 1.21 as well so im at a loss.

onebeastchris commented 1 month ago

The stone cutter thing was fixed, update Geyser - as for dispenser recipes, if it still occurs with the latest build and with a datapack, please link it here

onebeastchris commented 1 month ago

Hm, just realized that my testing build didn't have that stonecutter fix included. I'll rebuild it, one sec

onebeastchris commented 1 month ago

New download: https://github.com/onebeastchris/Geyser/actions/runs/10151686741 this has the latest master changes which include the stonecutter fix, and also the debug line to print relevant details

onebeastchris commented 1 month ago

Please try updating Geyser to latest version & see if the issue persists. Thanks!