search

GeyserMC / Geyser

A bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock Edition.
https://geysermc.org
MIT License
4.7k stars 673 forks source link

Custom enchantments using the new method are not visible in the tooltip #5024

Open ChrisTVH opened 1 week ago

ChrisTVH commented 1 week ago

Describe the bug

To Reproduce

Expected behaviour

Screenshots / Videos

Bedrock:

image

Java:

image

Server Version and Plugins

Server version

Geyser Dump

https://dump.geysermc.org/Q9zwWXq7OBIDbbvb0fxKnf8WbQwye5Cg

Geyser Version

Geyser 2.4.2-b666 (git-master-9dad34d)

Minecraft: Bedrock Edition Device/Version

v1.21.20/v1.21.23

Additional Context

No response

onebeastchris commented 1 week ago

https://geysermc.org/wiki/geyser/translations#modifyingadding-minecraft-java-translations This looks like missing Java translation strings to me (Geyser doesn't download Java edition resource packs which would contain them). Try adding the translation strings as shown on the wiki?

ChrisTVH commented 1 week ago

https://geysermc.org/wiki/geyser/translations#modifyingadding-minecraft-java-translations This looks like missing Java translation strings to me (Geyser doesn't download Java edition resource packs which would contain them). Try adding the translation strings as shown on the wiki?

Are you telling me I can add it myself? I looked at what you told me, but that folder is empty, probably because I have geyser on my proxy. But according to what you tell me, I would have to just add it myself wouldn't I?

onebeastchris commented 1 week ago

Yes, you'd need to create that folder yourself, and add the language files from the java resource pack there

ChrisTVH commented 1 week ago

Yes, you'd need to create that folder yourself, and add the language files from the java resource pack there

I was researching and reading the wiki and I see that just adding the missing enchantment strings would be enough. But I don't know if I can get the language files directly from the server.

onebeastchris commented 1 week ago

The resource pack that is sent to the Java client will contain them

ChrisTVH commented 1 week ago

The resource pack that is sent to the Java client will contain them

Right now my head, is trying to think how do I get that from the client, but anyway I have a command to pull the components of the objects from there I can get the id, which I require to do what it tells me in the wiki.

ChrisTVH commented 1 week ago

The resource pack that is sent to the Java client will contain them

I tried to do as you said and it didn't work.... image

onebeastchris commented 1 week ago
ChrisTVH commented 1 week ago
  • Did you restart the server after adding the translations?
  • What text is shown to players when you run /tellraw @a {"translate":"enchantment.minecraft.confusion"}? The translation that you added, or the key?
  • Is the client using the es_es language?

Well, I used a command called /itemnbt to get that, from there I got the ID of each enchantment.

The other plugins detect the enchantments with that id as if they were native to miencraft, because of what I mentioned in the issue.

But I'm going to try that and see.

So I forgot to tell you, I did restart the proxy and the server.

ChrisTVH commented 1 week ago

This appears: image

onebeastchris commented 1 week ago

is that on a java client? If so, it would indicate that the enchantment IDs that you checked aren't actually the language keys that are used for the enchantment.

I'm not able to try and debug the issue at the moment, I'll try and do that later today/tomorrow.

ChrisTVH commented 1 week ago

is that on a java client? If so, it would indicate that the enchantment IDs that you checked aren't actually the language keys that are used for the enchantment.

I'm not able to try and debug the issue at the moment, I'll try and do that later today/tomorrow.

I tried it in bedrock and it came out the same as well. This gets complicated if the component information says something else and it is not the real one.

image

onebeastchris commented 1 week ago

Could you try using the linked PR's Geyser build? It can be downloaded under the Checks tab.

ChrisTVH commented 1 week ago

Could you try using the linked PR's Geyser build? It can be downloaded under the Checks tab.

Wuaaah they are finally visible. image image

ChrisTVH commented 1 week ago

Some bugs came up on console, so I'll pass them along here. https://mclo.gs/KT1lAq9

Camotoy commented 1 week ago

Would you be able to send the full latest.log file? (Through MCLogs is fine) Thanks.

ChrisTVH commented 1 week ago

Would you be able to send the full latest.log file? (Through MCLogs is fine) Thanks. Here you can capture all the errors I made during the test.

https://mclo.gs/9kZoTlP

onebeastchris commented 5 days ago

The last issue should be resolved by https://github.com/GeyserMC/Geyser/pull/4849 - the latest version of Geyser should at least show the enchantment name properly.

ChrisTVH commented 4 days ago

The last issue should be resolved by #4849 - the latest version of Geyser should at least show the enchantment name properly.

I'm sorry for the delay, I tested the build of #4849 today and I got a comment and the enchants stopped appearing again. image

ChrisTVH commented 4 days ago

As a side note, the errors that used to appear when trying to view custom enchantments are no longer displayed, but now they are not.

Camotoy commented 3 days ago

Please try the latest Geyser build.

ChrisTVH commented 2 days ago

Please try the latest Geyser build.

I am going to use geyser standalone since I am moving a dedicated one, I will comment the results.

ChrisTVH commented 2 days ago

It works very well and without errors, the thing is that you can't use the custom enchantments to enchant objects from bedrock using the anvil.

ChrisTVH commented 20 hours ago