This PR should handle most of the goat horn changes in 1.21.2. Goat horn instruments have been turned data-driven and this PR takes account for that. This PR should also fix item cooldowns and implement support for tracking cooldown groups in Geyser, although Bedrock still doesn't always support showing custom item cooldowns visually.
Some basic testing has been done, both vanilla- and non-vanilla goat horns seem to translate correctly and have correct their cooldowns applied and sounds played. Some notes:
GeyserInstrument may need a better name, but Instrument conflicts with MCPL.
In JavaCooldownTranslator, it says that
Not every item, as of 1.19, appears to be server-driven. Just these two.
(These two being goat horns and shields) is this still the case, or are there now more server-driven item cooldowns for Bedrock?
Non-vanilla goat horns show a double tooltip (see attached screenshot), is it possible to hide the vanilla tooltip or not?
Unrelated to the main topic of this PR, a unnecessary TODO in Enchantment has been removed and a small error in the Javadoc there has been fixed.
This PR should handle most of the goat horn changes in 1.21.2. Goat horn instruments have been turned data-driven and this PR takes account for that. This PR should also fix item cooldowns and implement support for tracking cooldown groups in Geyser, although Bedrock still doesn't always support showing custom item cooldowns visually.
Some basic testing has been done, both vanilla- and non-vanilla goat horns seem to translate correctly and have correct their cooldowns applied and sounds played. Some notes:
GeyserInstrumentmay need a better name, butInstrumentconflicts with MCPL.In
JavaCooldownTranslator, it says that(These two being goat horns and shields) is this still the case, or are there now more server-driven item cooldowns for Bedrock?
Enchantmenthas been removed and a small error in the Javadoc there has been fixed.