Open artnaseef opened 1 year ago
Still happening?
Honestly - not sure where this is now. I haven't looked at it in a year. This is the first feedback I've gotten.
Recently someone has contributed some changes that fix some weird chunk behaviours. Maybe this is the same issue and it's fixed now. Or this is something else.
OK, I'll take a look. I need to try to get to the latest version of Minecraft, so this is a good time to check it out. I should be able to work on it this week.
Turned out to be a super busy week. Hoping this coming week is better.
Getting this stack trace on call to MinecraftCodecHelper.readChunkSection() with data from ClientboundLevelChunkWithLightPacket.getChunkData(). The packet parse is coming from a stock, vanilla Minecraft 1.20.1 server:
Debugging it, the cause appears to be an attempt to read past the end of the buffer here:
https://github.com/GeyserMC/MCProtocolLib/blob/master/src/main/java/com/github/steveice10/mc/protocol/codec/MinecraftCodecHelper.java#L689
Noticed the following code is new:
Changing it as follows fixes my problem. Looking for advice here.
Thoughts?