Add support for HAProxy PROXY protocol

GeyserMC / PacketLib

A library for packet-based networking between clients and servers.

MIT License

80 stars 40 forks source link

Add support for HAProxy PROXY protocol #24

Closed mikroskeem closed 3 years ago

mikroskeem commented 3 years ago

See:

ghost commented 3 years ago

Regarding clientAddress:

Since it's only for proxy protocol support, I would prefer if it were stored in the flags along with the enable Boolean.
Regardless, the constructor without it should not be deprecated, as users not using proxy support don't need it.

mikroskeem commented 3 years ago

Requested changes have been made.

ghost commented 3 years ago

Only comment I have left is the Deprecated on the constructor should be removed. Other than that, looks good to me.

I assume you've tested to make sure everything still works?

mikroskeem commented 3 years ago

I assume you've tested to make sure everything still works?

I would've liked to run proper mvn clean package before merging and confirmed explicitly (because how maven can mess up with its caching sometimes); but yeah things worked out fine.

Thanks for merging it.