GeyserMC / ThirdPartyCosmetics

An extension that adds support for loading ears and other third party cosmetics on java players
MIT License
15 stars 4 forks source link

Fix Capes Not Appearing #11

Closed 200Tigersbloxed closed 2 months ago

200Tigersbloxed commented 2 months ago

This PR fixes a lost implementation where capes would be re-scaled to fit Bedrock. Bedrock expects capes to be 64 pixels wide and 32 pixels tall. If this requirement is not met, then capes will not appear on the client. This feature was implemented previously in Geyser, but appeared to have not been ported to this extension. This PR fixes that!

This PR will automatically re-scale and fit capes if they are not already 64 pixels by 32 pixels, making it so bedrock clients will have no issues loading capes.

[!NOTE]

  • All of the code committed to Utils was pulled directly from GeyserMC as to not cause any re-implementation conflicts.
  • This PR does not cache images like Geyser used to do. This may be useful in the future

Related Issues:

Thanks much! 🧡