search

GeyserMC / ThirdPartyCosmetics

An extension that adds support for loading ears and other third party cosmetics on java players
MIT License
15 stars 4 forks source link

High resolution capes won't get displayed correctly. #5

Closed Fridtjof-DE closed 2 weeks ago

Fridtjof-DE commented 11 months ago

Describe the bug

High resolution capes won't get displayed correctly on Bedrock clients because the original image just gets cropped out to the default resolution.

To Reproduce

  1. Join a server that allows third party capes and look at a player wearing a hd cape from LabyMod or OptiFine in example.

Expected behaviour

Capes should be display correctly or if not possible at least be scaled down.

Screenshots / Videos

Bedrock: Screenshot (4)

Java: 2024-01-02_02 52 10

Server Version and Plugins

No response

Geyser Dump

No response

Geyser Version

2.2.0-SNAPSHOT (git-master-46bde0c)

Minecraft: Bedrock Edition Device/Version

any

Additional Context

No response

rtm516 commented 6 months ago

I believe this is a bedrock limitation and nothing we can do but downscale the capes, could you provide an example texture for it? I've tried testing with one I found online and it didn't even show up on the client

james090500 commented 3 weeks ago

Old geyser used to downscale the capes. You can test with capes from here https://minecraftcapes.net/gallery

rtm516 commented 2 weeks ago

This was fixed in https://github.com/GeyserMC/ThirdPartyCosmetics/commit/f6e00d6877c46e9a4f8c73a62fca09536c6f9d84 / https://github.com/GeyserMC/ThirdPartyCosmetics/pull/11