Custom capes don't show for some reason

GeyserMC / ThirdPartyCosmetics

An extension that adds support for loading ears and other third party cosmetics on java players

MIT License

12 stars 4 forks source link

Custom capes don't show for some reason #8

Closed JimmyJxt closed 1 week ago

JimmyJxt commented 3 months ago

https://dump.geysermc.org/4rMd1qsuop9OAtRJFByVRnS9pZaDhboF

rtm516 commented 2 months ago

Can you provide information about the cape?

Confirm your expecting it to show on a java player from a bedrock client
Copy of the texture
Provider it's on
Account name it's attached to

JimmyJxt commented 2 months ago

It's just every capes, optifine, minecraftcapes

200Tigersbloxed commented 2 weeks ago

I'll add on to this.

I can confirm that the Bedrock client is awaiting a cape on a Java player by adding simple debugging
Cape Link
Optifine
200Tigersbloxed

Here's some screenshots

I've also tried this in numerous environments. Velocity, Paper, and Paper with only two plugins (Geyser-Spigot and floodgate-spigot).

200Tigersbloxed commented 2 weeks ago

I have found the problem. Optifine capes are 92x44, whereas regular capes are 64x32. After resizing the Optifine cape, it actually loads. It's just offset and looks odd.

200Tigersbloxed commented 1 week ago

And, tada! After reimporting the old scaling code, it now works great!

If you'd like, I can open a PR for this fix or attach a build if further investigation is needed. However, this issue should be renamed as it is now known what causes this issue! (and what the fix is)

rtm516 commented 1 week ago

Thanks for looking into this @200Tigersbloxed

More than happy for you to open a PR fixing the scaling issue.