Ghadjeres / DeepBach

code accompanying "DeepBach: a Steerable Model for Bach Chorales Generation" paper
MIT License
500 stars 131 forks source link

The tailor generation is not working #73

Closed RuiYang12345 closed 3 years ago

RuiYang12345 commented 3 years ago

According to the video 'Interactive chorale composition using DeepBach' on Youtube, the plugin is able to corresponding counterpoint voices if changing one voice of one measurement.

But the plugin that I install can not generate new harmonization according to my change. It only changes base on the original voice. For example, as the figure following, when I change the A to D in bar 2, deepbach will still generate A note to rewrite the note I changed.

zhong

hou

527cc0030ebc650923512ce67c877f7e

Ghadjeres commented 3 years ago

Hi @RuiYang12345 , Thanks a lot for your detailed issue! The MuseScore plugin was indeed doing what you described. In fact I hardly checked this part of the code when rewriting it in Pytorch. Sorry for this. Finally I solved this issue in #74 : Now:

Remember that you can provide a --num_iterations argument to the musescore_flask_server.py if you think the default value takes too much time. Hope it will work on your side. Also do not forget to reload the plugins in MuseScore3: just replacing the .qml file won't work.

And here is a small chorale composed with this plugin! https://www.youtube.com/watch?v=X72YHyaTIUE&feature=youtu.be

RuiYang12345 commented 3 years ago

Hi Ghadjeres,

It is working now, thank you so much!