Ghamza-Jd / jarust

A janus client SDK in Rust 🦀
Apache License 2.0
8 stars 3 forks source link

feat(plugins): Add async methods and events for Videoroom plugin #118

Closed koefmatt closed 1 month ago

koefmatt commented 2 months ago

This PR implements the asynchronous methods and associated events of the Janus videoroom plugin API. Additionally it adds the missing synchronous methods for RTP forwarding.

It's difficult to implement the events as the documentation seems to be wrong or at least incomplete for some of them. Some of the provided structs can't be deserialized easily because they share common keys and values for identification.

Ghamza-Jd commented 2 months ago

Nice, Thanks!

I'll take a look at this tomorrow morning.

Ghamza-Jd commented 2 months ago

It's difficult to implement the events as the documentation seems to be wrong or at least incomplete for some of them.

No worries, planning for 1.0 which will include stabilisation and more testing. Part of it is APIs that seem a bit fiddly and/or poorly documented can be flagged as unstable until we try them in some sample apps.