Automatically Detect Client System Theme

GhassenEljday / react-mobile-app-button

Welcome to our versatile React component designed to seamlessly integrate download buttons for iOS App Store, Google Play Store, and Huawei AppGallery. Enhance your users' experience by providing effortless access to your mobile app on popular platforms. Elevate your app's visibility and accessibility today!

https://www.npmjs.com/package/react-mobile-app-button?activeTab=readme

40 stars 4 forks source link

Automatically Detect Client System Theme #2

Closed mohamed-Dhia closed 1 year ago

mohamed-Dhia commented 1 year ago

This pr implements the useSystemTheme to read and watch the current client theme and display the buttons accordingly. It also includes some fixes:

Adds classnames to the dependency list (was causing missing dependency error)
Abstracts different logos for each theme
Organizes types (many are duplicated) to types/index.d.ts

keeps up the good work @GhassenEljday ✌️

GhassenEljday commented 1 year ago

Hey @mohamed-Dhia

Thank you for the PR I really appreciate your effort, however, there is no need to automatically detect the client system theme.

mohamed-Dhia commented 1 year ago

my honest reaction 🗿