Open GhausAliKhan opened 1 year ago
Hi @GhausAliKhan, @peter-mwovi ,
Great job so far! π You've done well, and you're almost there for the next project βοΈ, but there are a few issues π that you still need to work on.
It's okay to have bugs in your code. π Please see this code review as an opportunity to learn practical coding skills and discover new tips that can improve your code quality π― and help you get even better πΌ.
I will guide you on how to address these areas down below π.
β
Has a link to their GitHub project. π
β
Solo cards are assigned to team members.
β
Students decided who is Student A
, Student B
group task
in the title are currently assigned to no one. As per project requirements, they should be assigned to someone. If both of you are working on the same group task, you can assign both of your names, just as you would for a solo task. If a group task is being tackled by just one person, it should be assigned accordingly. Please make sure to update your kanban board accordingly. ππ€π₯πEvery comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Contact me: Shahadat Hossain | |||
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Great Job π π You've done it. Your project is complete! There is nothing else to say ππ» β
Cheers, and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
We are a group of 2 people