search

GheodeAI / va_am

VA-AM (Various Advanced - Analogue Methods) is a Python package based on the deep learning enhancement of the classical statistical Analogue Method. It provides several tools to analyse climatological extreme events, particularly heat waves.
https://va-am.readthedocs.io/en/latest/
GNU General Public License v3.0
2 stars 0 forks source link

feature/generic names #33

Closed eugenioLR closed 2 months ago

eugenioLR commented 3 months ago

Everything commented in issue #32 is addressed in this PR. It still needs a bit of testing, but it can already be reviewed.

If this is uploaded, remember to update all your local files to comply with the new names of the configuration files. The changes are minimal but it won't work if you don't keep this in mind.

cosminmarina commented 3 months ago

I reviewed the changes and try some simple test. It seems to work properly. Thank you very much!

Anyway, I have a request to you @eugenioLR. Can we wait maybe... 2 or 3 days before merging this? I'm currently finishing issues #23 and #13 and it will be a mess if I have to update everything now.

If you're okey with that, I will want to end that 2 issues in 2 or 3 days, upload a new version v0.1.8 with this changes and, after that, merge this with develop, and create a v0.2.0 with #32 and #31. Also, with this delay, I think I can try some more test to this feature.

eugenioLR commented 3 months ago

That's ok. It can wait.