GhiXu / ACMMP

Multi-Scale Geometric Consistency Guided and Planar Prior Assisted Multi-View Stereo (TPAMI 2022)
MIT License
173 stars 28 forks source link

Fix v shaped propagation #16

Open sanskar107 opened 1 year ago

sanskar107 commented 1 year ago

For propagation of red pixels, the current impl is actually using red pixels (supposed to be black) for the V-shaped comparison.

For e.g. left_near, let's assume center pixel is red. Current Impl - int pointTemp = left_near - (1 + i) - i * width; Here left_near is pixel on the left of center pixel, so it is black pixel. then for i==0, pointTemp resolves to left_near - 1, which is again red, same as center pixel.

This is fixed in this PR. Now, for i==0, pointTemp resolves to left_near - 1 - width, this is one pixel on diagonally up-left of left_near, which is what we want.