search

GhiXu / Geo-Neus

Geo-Neus: Geometry-Consistent Neural Implicit Surfaces Learning for Multi-view Reconstruction (NeurIPS 2022)
MIT License
290 stars 18 forks source link

Forget to find the root of the denominator when calculating NCC? #14

Closed YZsZY closed 1 year ago

YZsZY commented 1 year ago

Hello Author! According to equation 22 in the paper, the denominator should have a root sign after calculating the variance of the refer and source image's patches, however, I checked the code corresponding to this section and it seems that there is no root sign for the denominator, so I came to ask if the code is written wrong? https://github.com/GhiXu/Geo-Neus/blob/bb17c755c4de5e59ff7be4587b3fc90985937104/models/renderer.py#L553

YZsZY commented 1 year ago

I noticed that the squaring of the numerator is done, so wouldn't that be a bad way to calculate the LNCC?