Closed fmagin closed 1 year ago
Grrr...
I have no idea what's causing this, and I kinda don't wanna mess with this. But if you don't have the time, I might give it a go...
Roughly: the new buildExtension.gradle
has a function checkGradleVersion()
that is called early on.
The relevant part is
import org.gradle.util.GradleVersion;
def checkGradleVersion() {
GradleVersion min = null;
GradleVersion max = null;
try {
min = GradleVersion.version("${rootProject.GRADLE_MIN}") // This is line 340
}
catch (IllegalArgumentException e) {
String defaultMin = "1.0"
println "Invalid minimum Gradle version specified in application.properties...using ${defaultMin}"
min = GradleVersion.version(defaultMin)
}
try {
rootProject
at that time is root project 'ghidra-jupyter-kotlin'
(by just throwing a println rootProject
in there).
If I comment out the call to it, I get errors during compileJava
:
* What went wrong:
Execution failed for task ':GhidraJupyterKotlin:compileJava'.
> invalid source release: 17
but I think those are related to something about my local setup being broken, somehow gradle uses java8.
So the problem is why this property is missing, and why it is only missing with this plugin, the other plugins I tested don't seem to have this problem
Okay, I understood what is going on, found workarounds and opened an issue in the Ghidra repo itself. https://github.com/NationalSecurityAgency/ghidra/issues/5540
Trying to build the extension for Ghidra 10.3 fails with:
I'm not sure yet what is going on, other plugins don't seem to have this problem