GhidraJupyter / ghidra-jupyter-kotlin

MIT License
115 stars 10 forks source link

Automatic extension download fails during `ghidra-jupyter install-extension` due to misnamed release zip in v1.1.1 #6

Closed the6p4c closed 2 years ago

the6p4c commented 3 years ago

The Python install utility expects the zip file to follow the regex GhidraJupyterKotlin[v0-9.\-_]*\.zip and fails to find the zip for the most recent release (v1.1.1) as the release zip is named ghidra_9.2.2_PUBLIC_20210305_GhidraJupyterKotlin.zip.

Output:

Downloading Ghidra extension from None
Traceback (most recent call last):
  File "[path_to_python]\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "[path_to_python]\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "[path_to_python]\Scripts\ghidra-jupyter.exe\__main__.py", line 9, in <module>
  File "[path_to_python]\lib\site-packages\ghidra_jupyter\installer.py", line 137, in main
    install_extension(args.ghidra, args.extension_path, args.extension_url)
  File "[path_to_python]\lib\site-packages\ghidra_jupyter\installer.py", line 76, in install_extension
    download_file(extenion_url, extension_path)
  File "[path_to_python]\lib\site-packages\ghidra_jupyter\installer.py", line 17, in download_file
    with requests.get(url, stream=True) as response:
  File "[path_to_python]\lib\site-packages\requests\api.py", line 72, in get
    return request('get', url, params=params, **kwargs)
  File "[path_to_python]\lib\site-packages\requests\api.py", line 58, in request
    return session.request(method=method, url=url, **kwargs)
  File "[path_to_python]\lib\site-packages\requests\sessions.py", line 494, in request
    prep = self.prepare_request(req)
  File "[path_to_python]\lib\site-packages\requests\sessions.py", line 437, in prepare_request
    hooks=merge_hooks(request.hooks, self.hooks),
  File "[path_to_python]\lib\site-packages\requests\models.py", line 305, in prepare
    self.prepare_url(url, params)
  File "[path_to_python]\lib\site-packages\requests\models.py", line 379, in prepare_url
    raise MissingSchema(error)
requests.exceptions.MissingSchema: Invalid URL 'None': No schema supplied. Perhaps you meant http://None?