search

Ghiftee / Microverse-Js-capstone

This project is a web app created with a Tv maze API which displays tv series, shows likes for each series and comments for the series too.
MIT License
4 stars 1 forks source link

Kanban board review #18

Closed Ghiftee closed 3 years ago

Ghiftee commented 3 years ago

https://github.com/Ghiftee/Microverse-Js-capstone/projects

Note: There are two people in our team:

Dipeshtwis commented 3 years ago

Hi @tacettinkustu and @Ghiftee,

:+1: This is good to make it this far, your project is really nice, congratulations on the good work you have done so far.

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

assigned_card

Your's issue card look like:

Screenshot from 2021-08-02 18-56-19

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Dipesh Kumar

As described in the Code reviews limits policy you have a limited number of reviews per project(check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Ghiftee commented 3 years ago

We removed cards with student c and assigned all the other cards to the related students

bellom commented 3 years ago

https://github.com/Ghiftee/Microverse-Js-capstone/projects

Note: There are two people in our team

[Optional]

As mentioned by the previous reviewer, It's better if you mention the two names and also link who is person A and person B in this issue description.

bellom commented 3 years ago

Hi @tacettinkustu and @Ghiftee,

👍 This is good to make it this far, your project is really nice, congratulations on the good work you have done so far.

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

  • [x] For a team with 2 people - All cards with Student C suffix on the template should be removed from the template. Number of cards in Backlog should be equal to 15. Currently, you have 17 cards in backlog.
  • [x] Also decide who is Student A, Student B. So each card with Student A in its title should always be assigned to the same student (and analogical for other students).
  • [x] The issue should use a circle with user's avatar on each card. See the example below:
assigned_card

Your's issue card look like:

Screenshot from 2021-08-02 18-56-19

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

  • It's better if you mention the two name and also link who is person A and person B in this issue description.

Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Dipesh Kumar

As described in the Code reviews limits policy you have a limited number of reviews per project(check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Ghiftee @tacettinkustu, Good job making almost all the necessary corrections from the previous reviewer, but you removed more than 5 cards on the board, you're supposed to have 15 cards, but I'm seeing 13 Screenshot: image

If I may ask, is there any issue that caused you to removed more cards?

Kindly add the missing cards.

bellom commented 3 years ago

Hi Team 👏 ,

Good job making almost all the necessary corrections from the previous reviewer.

Required Changes ♻️

Check the comment above the review.

Kindly add the 2 missing cards, you have 13 cards currently in Backlog instead of 15.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Ghiftee commented 3 years ago

We have added the two cards so we have a total of 15 cards now

carlos-ssh commented 3 years ago

Hi @Ghiftee & @tacettinkustu,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.