search

Ghost-Proxy / Voluspa

Ghost Proxy Proto-Warmind AI
MIT License
2 stars 1 forks source link

Gaminator - It's Alive! #52

Closed OxyOCE closed 4 years ago

OxyOCE commented 4 years ago

Too bad reactions are s l o w to await, Could possibly swap out for a text based interface? But then that's pretty much just the system we already have.

EDIT 1: Actually, could clear just user reactions between pages and remove surplus bot reactions on the last page when needed. That could be a good option?

EDIT 2: Unfortunately the Discord API doesn't have an endpoint for inserting a reaction at an index or editing a reaction, so EDIT 1 isn't really an option.

EDIT 3: I also tried parallelising the reaction add with asyncio.as_completed but surprisingly, that didn't help with speed at all. Must be internal rate limiting to the Discord API?

RecursiveHook commented 4 years ago

Ah, yah, noticed the reaction population can be rather slow to start.

In regard to options for performance, yah totally concur with your idea of clearing the reactions and removing any extraneous ones, would imagine that should be much faster.

RecursiveHook commented 4 years ago

Ah ok, noted regarding the options for performance (hmm, that is a bit surprising).

RecursiveHook commented 4 years ago

Did a cursory review, looks good so far, post some rest will do a deeper pass, and then we can ship it. :shipit:

OxyOCE commented 4 years ago

Alright, altered as discussed. The new UI is much better without clearing the reactions between pages. Note that when we add / remove other games it may be good to tune EMBED_MAX_LINES so that the last page's size is as close as possible to the other page's size's.

RecursiveHook commented 4 years ago

Awesome, everything looks great! This is a really solid feature and great value add. Thanks very much for your work and time on this Oxy, much appreciated! 😄