search

Ghost-chu / QuickShop-Reremake

QuickShop is a shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop provides are ever needed by a player.
GNU General Public License v3.0
103 stars 147 forks source link

Eng lang broken #1537

Closed SkeletonAce closed 2 years ago

SkeletonAce commented 2 years ago

Description

My customised messages for shops and in chat messages are erased with the most recent update, Shop are also all showing out of stock.

Steps to reproduce

update to 5.0.0.3

Expected Behaviour

I have custom message colours set up

Screenshots

2021-11-01_10 43 01

/qs paste URL

paste-6e60b698cf9d406d8b562a7b475f2490.txt

Additional Context

No response

Andre601 commented 2 years ago

I have a similar, yet different issue.

In my case are signs showing 2nd and 3rd line in white while using NBT API and right-clicking the signs... Not sure if the white text is a new, intentional change or if that is just a possible downside of NBT API, but it's a bit annoying.

2021-10-31_23 14 57

Ghost-chu commented 2 years ago

quickshop use new messages system, old messages.json no longer works.

Ghost-chu commented 2 years ago

white text not should be a part of the sign, i will check them, thanks for reporting

sandtechnology commented 2 years ago

quickshop use new messages system, old messages.json no longer works.

Should we write an auto-migrate system for message.json? since it's logic and file structure is very similar

Ghost-chu commented 2 years ago

@Andre601 @SkeletonAce This build should fixed strange white color: https://ci.codemc.io/job/Ghost-chu/job/QuickShop-Reremake-SNAPSHOT/1913/artifact/target/QuickShop.jar

For the Out Of Stock issue, I need more details. Please upload the paste.